From: Christopher Baines <mail@cbaines.net>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: 28583@debbugs.gnu.org
Subject: [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient.
Date: Sat, 30 Sep 2017 09:21:10 +0100 [thread overview]
Message-ID: <20170930092110.07a1e6dd@cbaines.net> (raw)
In-Reply-To: <f2cf0b50-9c16-0b9e-4029-03c8d3f30970@uq.edu.au>
[-- Attachment #1: Type: text/plain, Size: 2660 bytes --]
On Wed, 27 Sep 2017 21:56:04 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:
> Hi,
>
> Thanks for the patches.
>
>
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-httpclient): New variable.
> > ---
> > gnu/packages/ruby.scm | 51
> > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> > 51 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index 80d3bffd8..ff6be875f 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -3579,6 +3579,57 @@ It has built-in support for the legacy
> > @code{cookies.txt} and (home-page
> > "https://github.com/sparklemotion/http-cookie") (license
> > license:expat)))
> > +(define-public ruby-httpclient
> > + (package
> > + (name "ruby-httpclient")
> > + (version "2.8.3")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (rubygems-uri "httpclient" version))
> > + (sha256
> > + (base32
> > + "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99"))))
> > + (build-system ruby-build-system)
> > + (arguments
> > + '(;; TODO: Some tests currently fail
> > + ;; ------
> > + ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0
> > pendings,
> > + ;; 2 omissions, 0 notifications
> > + ;; 91.866% passed
> > + ;; ------
> > + ;; 6.49 tests/s, 22.41 assertions/s
> > + #:tests? #f
> > + #:phases
> > + (modify-phases %standard-phases
> > + (replace 'check
> > + (lambda* (#:key tests? #:allow-other-keys)
> > + (if tests?
> > + (zero?
> > + (system* "ruby"
> > + "-Ilib"
> > + "test/runner.rb"))
> > + #t)))
> Since tests? is #f, this is effectively dead code. But it could be
> useful to someone continuing the tests, I'm not fussed.
I'm keen to keep it, as the #:tests? #f has a TODO comment, maybe the
tests can be made to pass in the future.
> > + (add-after 'install 'wrap-bin-httpclient
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (wrap-program (string-append (assoc-ref outputs "out")
> > + "/bin/httpclient")
> > + `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME"))))
> > + #t)))))
> It would be preferable to move this to be part of the
> ruby-build-system as is done in e.g. python-build-system, but OK.
Agreed, I'll try and make some time to look at this.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-30 8:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 17:10 [bug#28583] [PATCH] Add es-dump-restore and dependencies Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json Christopher Baines
2017-09-27 12:03 ` Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 3/7] gnu: Add ruby-options Christopher Baines
2017-09-27 12:10 ` Ben Woodcroft
2017-09-24 17:17 ` [bug#28583] [PATCH 4/7] gnu: Add ruby-highline Christopher Baines
2017-09-27 12:37 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 5/7] gnu: Add ruby-progress_bar Christopher Baines
2017-09-27 12:43 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 6/7] gnu: Add ruby-rubyzip Christopher Baines
2017-09-28 8:34 ` Ben Woodcroft
2017-09-30 8:24 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore Christopher Baines
2017-09-28 8:38 ` Ben Woodcroft
2017-09-30 8:25 ` Christopher Baines
2017-09-30 10:32 ` Ben Woodcroft
2017-09-30 10:52 ` bug#28583: " Christopher Baines
2017-09-27 11:56 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines [this message]
2017-09-30 8:19 ` [bug#28583] [PATCH 1/8] " Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 2/8] gnu: Add ruby-multi-json Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 3/8] gnu: Add ruby-options Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 4/8] gnu: Add ruby-code-statistics Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 5/8] gnu: Add ruby-highline Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 6/8] gnu: Add ruby-progress_bar Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 7/8] gnu: Add ruby-rubyzip Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 8/8] gnu: Add ruby-es-dump-restore Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930092110.07a1e6dd@cbaines.net \
--to=mail@cbaines.net \
--cc=28583@debbugs.gnu.org \
--cc=b.woodcroft@uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).