From: Christopher Baines <mail@cbaines.net>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: 28583@debbugs.gnu.org
Subject: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline.
Date: Sat, 30 Sep 2017 09:23:07 +0100 [thread overview]
Message-ID: <20170930092307.0b8e7858@cbaines.net> (raw)
In-Reply-To: <6aeccdcc-1509-6440-7ee8-1ca4fc7615e8@uq.edu.au>
[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]
On Wed, 27 Sep 2017 22:37:39 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-highline): New variable.
> > ---
> > gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index 1ee03e066..9863d4b37 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
> > (("/bin/sh") (which "sh"))))
> > %standard-phases)))))
> >
> > +(define-public ruby-highline
> > + (package
> > + (name "ruby-highline")
> > + (version "1.7.8")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (rubygems-uri "highline" version))
> > + (sha256
> > + (base32
> > + "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
> > + (build-system ruby-build-system)
> > + (arguments
> > + `(#:tests? #f)) ;; TODO: Requires code_statistics
> I've attached a package for code_statistics, but adding it does not
> help because there appears to be something amiss in the Rakefile.
> This has been fixed in the not quite released 2.0.0 version, so the
> patch may be useful in future.
Awesome, thanks Ben. I've send an updated set of patches, including this
one now. It looks good to me.
> > + (native-inputs
> > + `(("bundler" ,bundler)))
> > + (synopsis
> > + "HighLine helps you build command-line interfaces")
> > + (description
> > + "HighLine provides a high-level IO library that provides
> > validation, +type conversion, and more for command-line interfaces.
> > +
> > +HighLine also includes a menu system for providing multiple
> > options to the +user.")
> I would combine the two sentences into one paragraph.
I've made this change in the updated patches.
> Otherwise LGTM.
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-30 8:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 17:10 [bug#28583] [PATCH] Add es-dump-restore and dependencies Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json Christopher Baines
2017-09-27 12:03 ` Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 3/7] gnu: Add ruby-options Christopher Baines
2017-09-27 12:10 ` Ben Woodcroft
2017-09-24 17:17 ` [bug#28583] [PATCH 4/7] gnu: Add ruby-highline Christopher Baines
2017-09-27 12:37 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines [this message]
2017-09-24 17:17 ` [bug#28583] [PATCH 5/7] gnu: Add ruby-progress_bar Christopher Baines
2017-09-27 12:43 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 6/7] gnu: Add ruby-rubyzip Christopher Baines
2017-09-28 8:34 ` Ben Woodcroft
2017-09-30 8:24 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore Christopher Baines
2017-09-28 8:38 ` Ben Woodcroft
2017-09-30 8:25 ` Christopher Baines
2017-09-30 10:32 ` Ben Woodcroft
2017-09-30 10:52 ` bug#28583: " Christopher Baines
2017-09-27 11:56 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 1/8] " Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 2/8] gnu: Add ruby-multi-json Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 3/8] gnu: Add ruby-options Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 4/8] gnu: Add ruby-code-statistics Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 5/8] gnu: Add ruby-highline Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 6/8] gnu: Add ruby-progress_bar Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 7/8] gnu: Add ruby-rubyzip Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 8/8] gnu: Add ruby-es-dump-restore Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930092307.0b8e7858@cbaines.net \
--to=mail@cbaines.net \
--cc=28583@debbugs.gnu.org \
--cc=b.woodcroft@uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).