From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyD2D-0005se-QW for guix-patches@gnu.org; Sat, 30 Sep 2017 04:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyD2A-0000sH-MJ for guix-patches@gnu.org; Sat, 30 Sep 2017 04:22:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyD2A-0000sA-Hv for guix-patches@gnu.org; Sat, 30 Sep 2017 04:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyD2A-0000jP-CT for guix-patches@gnu.org; Sat, 30 Sep 2017 04:22:02 -0400 Subject: [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient. Resent-Message-ID: Date: Sat, 30 Sep 2017 09:21:10 +0100 From: Christopher Baines Message-ID: <20170930092110.07a1e6dd@cbaines.net> In-Reply-To: References: <20170924181052.0219647c@cbaines.net> <20170924171717.3855-1-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/qbSQR0A9Irkp9yIEjsBqSk4"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ben Woodcroft Cc: 28583@debbugs.gnu.org --Sig_/qbSQR0A9Irkp9yIEjsBqSk4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 27 Sep 2017 21:56:04 +1000 Ben Woodcroft wrote: > Hi, >=20 > Thanks for the patches. >=20 >=20 > On 25/09/17 03:17, Christopher Baines wrote: > > * gnu/packages/ruby.scm (ruby-httpclient): New variable. > > --- > > gnu/packages/ruby.scm | 51 > > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > > 51 insertions(+) > > > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > > index 80d3bffd8..ff6be875f 100644 > > --- a/gnu/packages/ruby.scm > > +++ b/gnu/packages/ruby.scm > > @@ -3579,6 +3579,57 @@ It has built-in support for the legacy > > @code{cookies.txt} and (home-page > > "https://github.com/sparklemotion/http-cookie") (license > > license:expat)))=20 > > +(define-public ruby-httpclient > > + (package > > + (name "ruby-httpclient") > > + (version "2.8.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (rubygems-uri "httpclient" version)) > > + (sha256 > > + (base32 > > + "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99")))) > > + (build-system ruby-build-system) > > + (arguments > > + '(;; TODO: Some tests currently fail > > + ;; ------ > > + ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0 > > pendings, > > + ;; 2 omissions, 0 notifications > > + ;; 91.866% passed > > + ;; ------ > > + ;; 6.49 tests/s, 22.41 assertions/s > > + #:tests? #f > > + #:phases > > + (modify-phases %standard-phases > > + (replace 'check > > + (lambda* (#:key tests? #:allow-other-keys) > > + (if tests? > > + (zero? > > + (system* "ruby" > > + "-Ilib" > > + "test/runner.rb")) > > + #t))) =20 > Since tests? is #f, this is effectively dead code. But it could be=20 > useful to someone continuing the tests, I'm not fussed. I'm keen to keep it, as the #:tests? #f has a TODO comment, maybe the tests can be made to pass in the future. > > + (add-after 'install 'wrap-bin-httpclient > > + (lambda* (#:key outputs #:allow-other-keys) > > + (wrap-program (string-append (assoc-ref outputs "out") > > + "/bin/httpclient") > > + `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME")))) > > + #t))))) =20 > It would be preferable to move this to be part of the > ruby-build-system as is done in e.g. python-build-system, but OK. Agreed, I'll try and make some time to look at this. --Sig_/qbSQR0A9Irkp9yIEjsBqSk4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPU/ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XekIA//ctS95Enk7cHMMNh7RpBtHAgrFQhK2gz7XFrQxxxUh1iz6a8y1e8Ovw7H 4yOdQXe+yu0K4G1AojPOIpEAm0uE4vhVawB1dBRpHq8q9HO+pvqfYaHq9s9AhpQm drpIFEmhPDGRV2s3EYcBuPIW6tEcsmsVUC3Y7ZBu5fU/6h6z7iMoTEEKGGSBIglR xEaovLtkfLSxrUQqpp+/3wSh1N8GgXEtZ9aun4Zolt5WGJglyJnRPTLIbLT9i0I3 KSgbR82tckzYPxP/esaxAITNo77U9Opsjnfc+U+HrcElGBLRDEKrj0pVfczLtABG rSRqfSkLmKUVMxkP+iCZmesv1LW5wk0xk+LoyFpDVs8fXl3M8qgkuzv6HIMH2nxG joskRYAyJWKm7nY9LVBWqCQ0ShTlMCT6yTNOdOv4ydHCa56kz4YIze2o8ol9tWtV pW2wdxJ6H+IqnHOTJCaBDLq/rU4BCgNLsVNiM3uNTZ0otth15aza1HcgC/aGp4ba rlV9+NqXg3eeKJnE95l3bF4+d+foYGFdoY0EYebH21sTPDCnUUmo7TNS57/Gqhxd Tb4PK2JaUNBjgk6epz0eAEaq2DwaNQknE9mCYY+ORVXQEJpjpflgr75nQIitI5WY X7Qk/d1NDtYo25bJ22+sNYiPE/HOoJ2JE9hKtDFlWIv6ZRdtPzY= =XDCM -----END PGP SIGNATURE----- --Sig_/qbSQR0A9Irkp9yIEjsBqSk4--