* [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
@ 2017-08-06 14:12 manolis837
2017-08-07 18:22 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: manolis837 @ 2017-08-06 14:12 UTC (permalink / raw)
To: 27983
From: Manolis Ragkousis <manolis837@gmail.com>
* gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
in #:configure-flags.
---
gnu/packages/check.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 2ab5c0135..ddfcf1750 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -213,6 +213,8 @@ normally do not detect. The goal is to detect only real errors in the code
(base32
"1n5p1m2m3fjrjdj752lf92f9wq3pl5cbsfrb49jqbg52ghkz99jq"))))
(build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
(native-inputs
`(("python-2" ,python-2)))
(home-page "https://github.com/google/googletest/")
--
2.13.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
2017-08-06 14:12 [bug#27983] [PATCH] gnu: googletest: Build shared libraries manolis837
@ 2017-08-07 18:22 ` Leo Famulari
2017-08-08 11:31 ` Manolis Ragkousis
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2017-08-07 18:22 UTC (permalink / raw)
To: manolis837; +Cc: 27983
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote:
> From: Manolis Ragkousis <manolis837@gmail.com>
>
> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
> in #:configure-flags.
Does it still build the static library in this case? If not, do packages
that are currently using googletest need to be adjusted?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
2017-08-07 18:22 ` Leo Famulari
@ 2017-08-08 11:31 ` Manolis Ragkousis
2017-08-08 13:58 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Manolis Ragkousis @ 2017-08-08 11:31 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27983
Hello Leo
On 08/07/2017 09:22 PM, Leo Famulari wrote:
> On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote:
>> From: Manolis Ragkousis <manolis837@gmail.com>
>>
>> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
>> in #:configure-flags.
>
> Does it still build the static library in this case? If not, do packages
> that are currently using googletest need to be adjusted?
>
No it doesn't but I rebuilt all the packages that depend on googletest
and everything built and worked the same. No need for anything to be
adjusted.
Manolis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
2017-08-08 11:31 ` Manolis Ragkousis
@ 2017-08-08 13:58 ` Leo Famulari
2017-08-09 11:01 ` bug#27983: " Manolis Ragkousis
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2017-08-08 13:58 UTC (permalink / raw)
To: Manolis Ragkousis; +Cc: 27983
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Tue, Aug 08, 2017 at 02:31:51PM +0300, Manolis Ragkousis wrote:
> Hello Leo
>
> On 08/07/2017 09:22 PM, Leo Famulari wrote:
> > On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote:
> >> From: Manolis Ragkousis <manolis837@gmail.com>
> >>
> >> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
> >> in #:configure-flags.
> >
> > Does it still build the static library in this case? If not, do packages
> > that are currently using googletest need to be adjusted?
> >
>
> No it doesn't but I rebuilt all the packages that depend on googletest
> and everything built and worked the same. No need for anything to be
> adjusted.
Okay then, LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#27983: [PATCH] gnu: googletest: Build shared libraries.
2017-08-08 13:58 ` Leo Famulari
@ 2017-08-09 11:01 ` Manolis Ragkousis
0 siblings, 0 replies; 5+ messages in thread
From: Manolis Ragkousis @ 2017-08-09 11:01 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27983-done
Pushed to master.
Thank you Leo!
Manolis
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-09 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-06 14:12 [bug#27983] [PATCH] gnu: googletest: Build shared libraries manolis837
2017-08-07 18:22 ` Leo Famulari
2017-08-08 11:31 ` Manolis Ragkousis
2017-08-08 13:58 ` Leo Famulari
2017-08-09 11:01 ` bug#27983: " Manolis Ragkousis
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).