unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: 27983@debbugs.gnu.org
Subject: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Date: Tue, 8 Aug 2017 09:58:03 -0400	[thread overview]
Message-ID: <20170808135803.GA8806@jasmine.lan> (raw)
In-Reply-To: <0ee7654f-0abe-c9c4-597e-df2007e72164@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

On Tue, Aug 08, 2017 at 02:31:51PM +0300, Manolis Ragkousis wrote:
> Hello Leo
> 
> On 08/07/2017 09:22 PM, Leo Famulari wrote:
> > On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote:
> >> From: Manolis Ragkousis <manolis837@gmail.com>
> >>
> >> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
> >>   in #:configure-flags.
> > 
> > Does it still build the static library in this case? If not, do packages
> > that are currently using googletest need to be adjusted?
> > 
> 
> No it doesn't but I rebuilt all the packages that depend on googletest
> and everything built and worked the same. No need for anything to be
> adjusted.

Okay then, LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-08-08 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06 14:12 [bug#27983] [PATCH] gnu: googletest: Build shared libraries manolis837
2017-08-07 18:22 ` Leo Famulari
2017-08-08 11:31   ` Manolis Ragkousis
2017-08-08 13:58     ` Leo Famulari [this message]
2017-08-09 11:01       ` bug#27983: " Manolis Ragkousis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808135803.GA8806@jasmine.lan \
    --to=leo@famulari.name \
    --cc=27983@debbugs.gnu.org \
    --cc=manolis837@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).