From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39044)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1df2l1-000857-NW
	for guix-patches@gnu.org; Tue, 08 Aug 2017 07:33:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1df2kw-0002vT-QL
	for guix-patches@gnu.org; Tue, 08 Aug 2017 07:33:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42433)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1df2kw-0002v8-NV
	for guix-patches@gnu.org; Tue, 08 Aug 2017 07:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1df2kw-0002Z8-6o
	for guix-patches@gnu.org; Tue, 08 Aug 2017 07:33:02 -0400
Subject: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Resent-Message-ID: <handler.27983.B27983.15021919219623@debbugs.gnu.org>
References: <20170806141217.14626-1-manolis837@gmail.com>
	<20170807182248.GC10622@jasmine.lan>
From: Manolis Ragkousis <manolis837@gmail.com>
Message-ID: <0ee7654f-0abe-c9c4-597e-df2007e72164@gmail.com>
Date: Tue, 8 Aug 2017 14:31:51 +0300
MIME-Version: 1.0
In-Reply-To: <20170807182248.GC10622@jasmine.lan>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27983@debbugs.gnu.org

Hello Leo

On 08/07/2017 09:22 PM, Leo Famulari wrote:
> On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837@gmail.com wrote:
>> From: Manolis Ragkousis <manolis837@gmail.com>
>>
>> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
>>   in #:configure-flags.
> 
> Does it still build the static library in this case? If not, do packages
> that are currently using googletest need to be adjusted?
> 

No it doesn't but I rebuilt all the packages that depend on googletest
and everything built and worked the same. No need for anything to be
adjusted.

Manolis