From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: Mark H Weaver <mhw@netris.org>,
Marius Bakke <mbakke@fastmail.com>,
39146@debbugs.gnu.org,
Danny Milosavljevic <dannym@scratchpost.org>
Subject: [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig
Date: Mon, 10 Feb 2020 22:49:31 +0100 [thread overview]
Message-ID: <1581371371.3276.1@tobias.gr> (raw)
In-Reply-To: <20200210183831.7evt4ci6r3qtgfm5@gravity>
Jakub, all,
On Mon, Feb 10, 2020 at 7:38 PM, Jakub =?UTF-8?b?S8SFZHppb8WCa2E=?=
<kuba@kadziolka.net> wrote:
> On Thu, Jan 23, 2020 at 09:53:48PM -0500, Mark H Weaver wrote:
>> I like the approach of Tobias' proposed patch, but to avoid losing
>> information (most of the hash), how about changing:
>>
>> (string-append store (string-take hash 8) "…")
>>
>> to something like:
>>
>> (string-append store (string-take hash 2) "." (string-drop hash
>> 2))
>>
>> What do you think? Anyway, I don't feel strongly about it, and I
>> acknowledge that neither approach is perfect.
> I feel like the unicode character "…" makes it much more clear that
> the
> path has been modified, but it's a moot point considering that if
> someone might get confused by this, they probably won't be able to
> make
> use of the hash.
>
> However, now that I come back to this after some time, I realize that
> there is another solution:
>
> (string-append store (string-take hash 8) "<span></span>"
> (string-drop hash 8))
>
> This would neuter the reference without having any user-visible
> impact on
> about:buildconfig. What do you think?
The truncation of these very long paths was fully intended as a
feature, but if people do think they're actually useful I think this is
a clever hack worthy of Guix :-)
Have you tested whether copying & pasting still works fine with this?
Kind regards,
T G-R, adrift without mu4e
next prev parent reply other threads:[~2020-02-10 21:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 22:21 [bug#39146] [PATCH] gnu: icecat: Remove compiler paths from about:buildconfig Jakub Kądziołka
2020-01-21 17:37 ` [bug#39146] [PATCH v2] " Jakub Kądziołka
2020-01-21 17:52 ` Danny Milosavljevic
2020-01-22 21:23 ` Mark H Weaver
2020-01-23 8:37 ` Jakub Kądziołka
2020-01-24 2:53 ` Mark H Weaver
2020-02-10 18:38 ` Jakub Kądziołka
2020-02-10 20:24 ` Mark H Weaver
2020-02-10 21:49 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-02-12 19:45 ` [bug#39146] [PATCH v3] gnu: icecat: Remove about:buildconfig store references Jakub Kądziołka
2020-02-13 22:03 ` [bug#39146] [PATCH v4] " Jakub Kądziołka
2020-01-21 18:05 ` [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 1:34 ` [bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references Tobias Geerinckx-Rice via Guix-patches via
[not found] ` <20200122135107.73z6upacjwial3zq@zdrowyportier.kadziolka.net>
[not found] ` <87o8uvlgnn.fsf@nckx>
2020-01-22 14:39 ` Jakub Kądziołka
2020-01-22 20:13 ` [bug#39146] [PATCH v2] " Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 20:28 ` Marius Bakke
2020-01-22 20:50 ` Jakub Kądziołka
2020-02-26 21:33 ` bug#39146: Done: " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581371371.3276.1@tobias.gr \
--to=guix-patches@gnu.org \
--cc=39146@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=kuba@kadziolka.net \
--cc=mbakke@fastmail.com \
--cc=me@tobias.gr \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).