From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 39146@debbugs.gnu.org
Subject: [bug#39146] [PATCH v2] gnu: icecat: Remove about:buildconfig store references.
Date: Wed, 22 Jan 2020 21:50:47 +0100 [thread overview]
Message-ID: <20200122205047.dclrpcyispjwm4dr@zdrowyportier.kadziolka.net> (raw)
In-Reply-To: <20200122201313.27946-1-me@tobias.gr>
On Wed, Jan 22, 2020 at 09:13:13PM +0100, Tobias Geerinckx-Rice wrote:
> Jakub: I accidentally kept your copyright line in v1, but didn't actually use your code (although part of your comment survives :-). Is the Reported-by above acceptable?
I feel like Co-authored-by might fit better, but either is fine by me.
> + ;; Mangle the store references to compilers & other build tools in
> + ;; about:buildconfig, reducing IceCat's closure by 1 GiB on x86-64.
Minor² nit: I feel like this wording suggests this only matters on x64.
How about: reducing IceCat's closure by 1 GiB (measured on x86-64).
> + (substitute*
> + "dist/bin/chrome/toolkit/content/global/buildconfig.html"
> + (((format #f "(~a/)([0-9a-z]{32})" (%store-directory)) _ store hash)
> + (string-append store (string-take hash 8) "…")))
> + #t))
I don't know whether this is a supported use case, but... what if
(%store-directory) contains regex metacharacters?
Marius Bakke wrote:
> Is it possible to use 'remove-store-references' here?
For later reference, resolved on IRC:
http://logs.guix.gnu.org/guix/2020-01-22.log#213448
Regards,
Jakub Kądziołka
next prev parent reply other threads:[~2020-01-22 20:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 22:21 [bug#39146] [PATCH] gnu: icecat: Remove compiler paths from about:buildconfig Jakub Kądziołka
2020-01-21 17:37 ` [bug#39146] [PATCH v2] " Jakub Kądziołka
2020-01-21 17:52 ` Danny Milosavljevic
2020-01-22 21:23 ` Mark H Weaver
2020-01-23 8:37 ` Jakub Kądziołka
2020-01-24 2:53 ` Mark H Weaver
2020-02-10 18:38 ` Jakub Kądziołka
2020-02-10 20:24 ` Mark H Weaver
2020-02-10 21:49 ` Tobias Geerinckx-Rice via Guix-patches via
2020-02-12 19:45 ` [bug#39146] [PATCH v3] gnu: icecat: Remove about:buildconfig store references Jakub Kądziołka
2020-02-13 22:03 ` [bug#39146] [PATCH v4] " Jakub Kądziołka
2020-01-21 18:05 ` [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 1:34 ` [bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references Tobias Geerinckx-Rice via Guix-patches via
[not found] ` <20200122135107.73z6upacjwial3zq@zdrowyportier.kadziolka.net>
[not found] ` <87o8uvlgnn.fsf@nckx>
2020-01-22 14:39 ` Jakub Kądziołka
2020-01-22 20:13 ` [bug#39146] [PATCH v2] " Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 20:28 ` Marius Bakke
2020-01-22 20:50 ` Jakub Kądziołka [this message]
2020-02-26 21:33 ` bug#39146: Done: " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122205047.dclrpcyispjwm4dr@zdrowyportier.kadziolka.net \
--to=kuba@kadziolka.net \
--cc=39146@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).