From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43926) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1GwO-0005JN-NA for guix-patches@gnu.org; Mon, 10 Feb 2020 16:50:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1GwN-0000uG-JD for guix-patches@gnu.org; Mon, 10 Feb 2020 16:50:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49664) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1GwM-0000sS-Et for guix-patches@gnu.org; Mon, 10 Feb 2020 16:50:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1GwM-00058L-A6 for guix-patches@gnu.org; Mon, 10 Feb 2020 16:50:02 -0500 Subject: [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig Resent-Message-ID: Date: Mon, 10 Feb 2020 22:49:31 +0100 Message-Id: <1581371371.3276.1@tobias.gr> In-Reply-To: <20200210183831.7evt4ci6r3qtgfm5@gravity> References: <20200115222115.322ymuuqkwlnbl3v@zdrowyportier.kadziolka.net> <20200121173711.5gegrl233dtjneni@zdrowyportier.kadziolka.net> <20200121185202.4cfbdc37@scratchpost.org> <87muaf6v81.fsf@netris.org> <20200123083738.c5wd3mx2bk3a5xy7@zdrowyportier.kadziolka.net> <87k15h7eeg.fsf@netris.org> <20200210183831.7evt4ci6r3qtgfm5@gravity> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: Mark H Weaver , Marius Bakke , 39146@debbugs.gnu.org, Danny Milosavljevic Jakub, all, On Mon, Feb 10, 2020 at 7:38 PM, Jakub =3D?UTF-8?b?S8SFZHppb8WCa2E=3D?=3D=20 wrote: > On Thu, Jan 23, 2020 at 09:53:48PM -0500, Mark H Weaver wrote: >> I like the approach of Tobias' proposed patch, but to avoid losing >> information (most of the hash), how about changing: >>=20 >> (string-append store (string-take hash 8) "=85") >>=20 >> to something like: >>=20 >> (string-append store (string-take hash 2) "." (string-drop hash=20 >> 2)) >>=20 >> What do you think? Anyway, I don't feel strongly about it, and I >> acknowledge that neither approach is perfect. > I feel like the unicode character "=85" makes it much more clear that=20 > the > path has been modified, but it's a moot point considering that if > someone might get confused by this, they probably won't be able to=20 > make > use of the hash. >=20 > However, now that I come back to this after some time, I realize that > there is another solution: >=20 > (string-append store (string-take hash 8) "" > (string-drop hash 8)) >=20 > This would neuter the reference without having any user-visible=20 > impact on > about:buildconfig. What do you think? The truncation of these very long paths was fully intended as a=20 feature, but if people do think they're actually useful I think this is=20 a clever hack worthy of Guix :-) Have you tested whether copying & pasting still works fine with this? Kind regards, T G-R, adrift without mu4e =