From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Tobias Geerinckx-Rice <me@tobias.gr>, 39146@debbugs.gnu.org
Subject: [bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references.
Date: Wed, 22 Jan 2020 15:39:28 +0100 [thread overview]
Message-ID: <20200122143928.6cr5vc6vbspjqkrf@zdrowyportier.kadziolka.net> (raw)
In-Reply-To: <87o8uvlgnn.fsf@nckx>
On Wed, Jan 22, 2020 at 03:19:06PM +0100, Tobias Geerinckx-Rice wrote:
> Jakub,
>
> Did you mean to send this off-list? Either's fine by me.
Whoops, not at all. I need to configure mutt to default to
reply-to-all... adding the list back into CC.
> Jakub Kądziołka 写道:
> > Firstly, note that /gnu/store/ is not guaranteed to be the store path,
> > since this parameter can be changed by passing --with-store-dir to
> > ./configure.
>
> Er, whoops, of course. I was going to replace that after testing. By the
> time they'd finished I'd forgot.
>
> > I assume you tested this patch? When I tried to do my substitutions
> > after the expansion is done, but before the files are packaged into
> > a zip-like file, I couldn't find a good place to hook in the build.
>
> Indeed. The result is stored in lib/icecat/omni.ja, which is an
> uncompressed (so GC works) zip file.
>
> > Also, there's already some code to help with removing references in
> > guix/build/utils.scm (remove-store-references), but the result you get
> > with what you're proposing seems much more user-friendly.
>
> Heh, thank you! That's intentional. :-)
>
> Remove-store-references' length-preservation is great in some cases
> (compiled executables, binary data, weird code, …) but this wasn't a good
> fit.
>
> Thanks for taking a look; I'll test & send a (%store-directory) fix. Thanks
> for your enthousiastic contributions to Guix in general.
A short while after switching to Guix, I read this on Reddit:
| If you're looking to just use one of these distros without actively
| contributing back, I'd go with NixOS right now. If you're an enthusiast
| that wants to contribute to one of these two projects, GuixSD needs more
| help to reach critical mass.
( -- https://www.reddit.com/r/NixOS/comments/9zwiee/nixos_vs_guixsd/eb6zqcu/)
This, together with the fact that Guix is quite easy to hack on, has
inspired me to contribute.
> > Looks like you haven't updated your git in a while ;)
>
> Nope, just other people's.
>
> My Guix sqlite DB was corrupted beyond repair in December, I've been limping
> along using ‘guix pack’s from my build farm ever since, because it was never
> the ‘right time’ to reinstall…
>
> I blame Guix for making that even possible and relatively painless.
>
> Kind regards,
>
> T G-R
>
next prev parent reply other threads:[~2020-01-22 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 22:21 [bug#39146] [PATCH] gnu: icecat: Remove compiler paths from about:buildconfig Jakub Kądziołka
2020-01-21 17:37 ` [bug#39146] [PATCH v2] " Jakub Kądziołka
2020-01-21 17:52 ` Danny Milosavljevic
2020-01-22 21:23 ` Mark H Weaver
2020-01-23 8:37 ` Jakub Kądziołka
2020-01-24 2:53 ` Mark H Weaver
2020-02-10 18:38 ` Jakub Kądziołka
2020-02-10 20:24 ` Mark H Weaver
2020-02-10 21:49 ` Tobias Geerinckx-Rice via Guix-patches via
2020-02-12 19:45 ` [bug#39146] [PATCH v3] gnu: icecat: Remove about:buildconfig store references Jakub Kądziołka
2020-02-13 22:03 ` [bug#39146] [PATCH v4] " Jakub Kądziołka
2020-01-21 18:05 ` [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 1:34 ` [bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references Tobias Geerinckx-Rice via Guix-patches via
[not found] ` <20200122135107.73z6upacjwial3zq@zdrowyportier.kadziolka.net>
[not found] ` <87o8uvlgnn.fsf@nckx>
2020-01-22 14:39 ` Jakub Kądziołka [this message]
2020-01-22 20:13 ` [bug#39146] [PATCH v2] " Tobias Geerinckx-Rice via Guix-patches via
2020-01-22 20:28 ` Marius Bakke
2020-01-22 20:50 ` Jakub Kądziołka
2020-02-26 21:33 ` bug#39146: Done: " Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122143928.6cr5vc6vbspjqkrf@zdrowyportier.kadziolka.net \
--to=kuba@kadziolka.net \
--cc=39146@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).