From: Eric Bavier <bavier@posteo.net>
To: Antero Mejr <antero@mailbox.org>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 60266-done@debbugs.gnu.org
Subject: bug#60266: [PATCH] gnu: Add form.
Date: Wed, 22 Mar 2023 04:54:00 +0000 [thread overview]
Message-ID: <07209d425a70f9e21169478617feba541de5ca13.camel@posteo.net> (raw)
In-Reply-To: <87cz523ph5.fsf@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 2393 bytes --]
Antero,
Thank you for your effort in this review.
On Tue, 2023-03-21 at 18:53 +0000, Antero Mejr wrote:
> > > > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.
> > It does, but not for i386 to i686, which also often see sse2 flags in
> > build systems.
>
> I did some benchmarks on a few workloads with millions of terms. The
> "tunable" optimizations didn't consistently improve the
> performance. Sometimes it would be a couple percent faster, sometimes
> slower. So I didn't mark the package as tunable.
I was watching my system load while `parform` was running its tests, and things did not
seem compute bound, so the package being not tunable seems fine to me.
> > > I used the other homepage so people can skip the weird "license
> > > agreement" page at https://www.nikhef.nl/~form/.
> > Calling the GPL a license agreement is weird, and it doesn't help that
> > https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can
> > raise an issue about that upstream?
>
> I would prefer not to bother upstream further regarding the website,
> since I already had to ask them to change an invalid license statement
> in a file header (which they did).
Version 1 of the GPL used the term "license agreement" when describing itself, so the
phrasing is not *super* weird, just maybe a bit outdated. There are also plenty of free
software projects, e.g. nodejs, that present users with an "accept this license agreement"
prompt in their M$ installers.
I've pushed these patches in
15ee08ebf23ea6bc5be9fa157889419aa079076a and
31bed61b8278d3736cc29055d60db068a1160071
with a small adjustment to appease `guix lint`:
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -1873,6 +1873,9 @@ (define-public form
answers are returned in a textual mathematical representation. The size of
the considered expressions in FORM is only limited by the available disk space
and not by the available RAM.")
+ ;; XXX: Ignore this CVE to work around a name clash with the unrelated
+ ;; "neos/forms" package.
+ (properties '((lint-hidden-cve . ("CVE-2021-32697"))))
;; x86_64 only due to test failures on other platforms.
;; Developers say other platforms are not "tier 1" supported:
;; https://github.com/vermaseren/form/issues/426
Thanks again,
`~Eric
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]
next prev parent reply other threads:[~2023-03-22 4:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 1:15 [bug#60266] [PATCH] gnu: Add form Antero Mejr via Guix-patches via
2023-01-09 18:01 ` Eric Bavier
2023-03-16 1:15 ` Antero Mejr via Guix-patches via
2023-03-16 5:23 ` Liliana Marie Prikler
2023-03-21 18:53 ` Antero Mejr via Guix-patches via
2023-03-22 4:54 ` Eric Bavier [this message]
2023-02-19 22:42 ` [bug#60266] Algebra Andreas Enge
2023-03-16 1:07 ` [bug#60266] [PATCH v2 1/2] gnu: Add form Antero Mejr via Guix-patches via
2023-03-16 1:07 ` [bug#60266] [PATCH v2 2/2] gnu: Add parform Antero Mejr via Guix-patches via
2023-03-21 18:39 ` [bug#60266] [PATCH v3 1/2] gnu: Add form Antero Mejr via Guix-patches via
2023-03-21 18:39 ` [bug#60266] [PATCH v3 2/2] gnu: Add parform Antero Mejr via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07209d425a70f9e21169478617feba541de5ca13.camel@posteo.net \
--to=bavier@posteo.net \
--cc=60266-done@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).