From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oK3kIjiKGmTNQwAASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 05:55:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UKwdIjiKGmRIngAAG6o9tA (envelope-from ) for ; Wed, 22 Mar 2023 05:55:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58BD8230C3 for ; Wed, 22 Mar 2023 05:55:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peqV7-0005f1-6n; Wed, 22 Mar 2023 00:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peqV4-0005ej-Td for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peqV4-00024B-Jh for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peqV4-0007u3-Dj for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:02 -0400 Subject: bug#60266: [PATCH] gnu: Add form. Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60266 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Antero Mejr , Liliana Marie Prikler Cc: 60266-done@debbugs.gnu.org Mail-Followup-To: 60266@debbugs.gnu.org, bavier@posteo.net, antero@mailbox.org Received: via spool by 60266-done@debbugs.gnu.org id=D60266.167946086330323 (code D ref 60266); Wed, 22 Mar 2023 04:55:02 +0000 Received: (at 60266-done) by debbugs.gnu.org; 22 Mar 2023 04:54:23 +0000 Received: from localhost ([127.0.0.1]:33201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUR-0007t1-5E for submit@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUO-0007sm-Jj for 60266-done@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 20DD9240533 for <60266-done@debbugs.gnu.org>; Wed, 22 Mar 2023 05:54:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679460854; bh=0NvzuAPzPNBHS6w6zsq9QaT7PIB1BMOh94Bhyef9aJI=; h=Subject:From:To:Cc:Date:From; b=B/wkq4CwWxHHBPC32IBVnwzonaKnXqMlITMoaoTLE5w0BHXaxDfyz0SXbNSkld1Ud FoolEwTVm8QrmplB1dVhh8I4I9NGrosLipTRI5DKqK1SEvxIE42sxl8uAgN5AGnYJ+ Il1BtL1DhNWUSnNqEqEG3+x7AXVs9g5iY4eon/dM4VNpXGmXrL/wy+CCPT/5JZBKL8 GOr0J90lW8wuBv9+ANRSFQQMlzLNrRarQtcWRZCl7UPoQYlGcny2s7RyRNfrf2pLpE 5SREYiK2B8mbHnSbKGmqxXa7uBgr2EZyyR1ISABusREE8vG67rdMWnZ4OiPr78iafj NHJJHwmRq8dRQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhGN34dqDz9rxM; Wed, 22 Mar 2023 05:54:11 +0100 (CET) Message-ID: <07209d425a70f9e21169478617feba541de5ca13.camel@posteo.net> From: Eric Bavier Date: Wed, 22 Mar 2023 04:54:00 +0000 In-Reply-To: <87cz523ph5.fsf@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> <871qlpzebc.fsf@mailbox.org> <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> <87cz523ph5.fsf@mailbox.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hTd/EDLdswMGfsBU7HyM" MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679460920; a=rsa-sha256; cv=none; b=mHl/E/i9E5LtwQJoNEicjiF3+xL778eSE22pkjUZDc/hEasuoIOY5F/CgO9w4lXRxKGZS/ lCso96uX28R4rUbpsOGd5O3z9ZEhxdIUC+GueJRfqhOiwT0fVI20uv+8i7qzsgf+zva0GD wcFgimobj1s7X9eKiz9ymvSFhknQLPRsz9nLPOAz7sIQIGcRq+iu9DVVGn85NCwlrOLyTO IahO4DqI3oyOu6o7BRCIlX323spI4KT9JCI8FBshPOkZX3CPQz1GqR2K/VrXosdC4qJ1f4 6AfL3MgpSBVjcwknwG2CATJ8RLw6FfH3RijJirypPDQdVpZ/nxNzE74bLctKWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="B/wkq4Cw"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679460920; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vK4xtXjSIrsJW2pAjh47q5aVvLYXS36irfbN0UjKAbs=; b=RCvkSTqmZQMVUpwCxAXd31rPuj5+mY9WDIZnXj2Jcmx5RQozugKcaS7j1heO8FMGpO1Kay YtijEZ+dMPB4opps4vXvg44YDV4a1owTnib1Tvrnr4387/GRp7ujZcWRaqTI1InTp4eOS2 snjLwflpupHUGi49qbSMwvAuX+b1qxj1AN/9Lf0m9fvrxpwcGmp5WBL5oirkw8BNk09WA+ PqsA6XdvM8uKN303frAU4KaPcPwAQAKVMb/oW5zZgJP76kiOm6/zkssuhqrQBDrIdzqkbj urvYG6dpSLzqe2OZNyn/IoV6bLA+Qm4mKIKUIvtJrBvEp9LWCWxftGB2zju3ZA== X-Migadu-Spam-Score: 3.45 X-Spam-Score: 3.45 X-Migadu-Queue-Id: 58BD8230C3 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="B/wkq4Cw"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: DAO9ugyecYGt --=-hTd/EDLdswMGfsBU7HyM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Antero, Thank you for your effort in this review. On Tue, 2023-03-21 at 18:53 +0000, Antero Mejr wrote: > > > > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.= =20 > > It does, but not for i386 to i686, which also often see sse2 flags in= =20 > > build systems. >=20 > I did some benchmarks on a few workloads with millions of terms. The > "tunable" optimizations didn't consistently improve the > performance. Sometimes it would be a couple percent faster, sometimes > slower. So I didn't mark the package as tunable. I was watching my system load while `parform` was running its tests, and th= ings did not seem compute bound, so the package being not tunable seems fine to me. > > > I used the other homepage so people can skip the weird "license > > > agreement" page at https://www.nikhef.nl/~form/. > > Calling the GPL a license agreement is weird, and it doesn't help that= =20 > > https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can > > raise an issue about that upstream? >=20 > I would prefer not to bother upstream further regarding the website, > since I already had to ask them to change an invalid license statement > in a file header (which they did). Version 1 of the GPL used the term "license agreement" when describing itse= lf, so the phrasing is not *super* weird, just maybe a bit outdated. There are also p= lenty of free software projects, e.g. nodejs, that present users with an "accept this lic= ense agreement" prompt in their M$ installers. I've pushed these patches in=20 15ee08ebf23ea6bc5be9fa157889419aa079076a and 31bed61b8278d3736cc29055d60db068a1160071 with a small adjustment to appease `guix lint`: --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -1873,6 +1873,9 @@ (define-public form answers are returned in a textual mathematical representation. The size o= f the considered expressions in FORM is only limited by the available disk s= pace and not by the available RAM.") + ;; XXX: Ignore this CVE to work around a name clash with the unrelat= ed + ;; "neos/forms" package. + (properties '((lint-hidden-cve . ("CVE-2021-32697")))) ;; x86_64 only due to test failures on other platforms. ;; Developers say other platforms are not "tier 1" supported: ;; https://github.com/vermaseren/form/issues/426 Thanks again, `~Eric --=-hTd/EDLdswMGfsBU7HyM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJGBAABCgAwFiEEo6S0GQB0CHyn3laYvEXKZ+L40AcFAmQaiegSHGJhdmllckBw b3N0ZW8ubmV0AAoJELxFymfi+NAHilkP/RsIw/KHn2Yq5WQb93nUmKtlJo4cKbz2 qtH0AZbcTjRxWV3rgt0AFLjM6BHmvMM03AnpFudV3YG7y9O/BIsh3SwhzmpW9BVc KHLZumV2tK3UumEwASAKtUBXoxAFkY56yTJx6Mfx7m1zhbPj9RvqHnFLNTI711/2 uLfluhogAjpomoXMMNU/EYSnklxGJqmsqGXXsEqiGsmGzO3sWPnEZ+t3c6a29YWT 4BQOI251wYxyX24FYUYO1YQHnaOyF6808iGMDa1aIPsxMr0goz9IAR3faeNSSeCp yJmZ9kCZVWs7acYyCXGClS+n3wVtWYLXdy/zhzhLEKKlbrx+cJpU1IICIHMSNQMX jfUmlfc3Rp8Jue3xi5YukMI8VW4++2N29QhF+1B/xn3a9seTkqTC1u82Jtc6uYWv CWBQH+pa2Yp4fx+xTO048QNqZnQM3fQq/1CBsIRkQFmn2iwsArhpNKDEiNoZF77H LI6iiVpFJIaRJfhHNF/L4mKWiASGwKpFXQEEIjEWk1K1RChK5B7lx+QwH/dwRIe6 vDzFEDJjhwlECjFXkC08BSzuTm1Z5ZFfqVuHj4pYC5rZiTVwdLRzdCLR654s3CZd uceMbyoG0k0hp2nReMr7Wn3GuCni16xdWswCM4qo/s/gVoviMRss3+qOzLUtO6qd Rj5ALQB9zy/l =xtxq -----END PGP SIGNATURE----- --=-hTd/EDLdswMGfsBU7HyM--