From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Antero Mejr <antero@mailbox.org>, Eric Bavier <bavier@posteo.net>
Cc: 60266@debbugs.gnu.org
Subject: [bug#60266] [PATCH] gnu: Add form.
Date: Thu, 16 Mar 2023 06:23:09 +0100 [thread overview]
Message-ID: <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> (raw)
In-Reply-To: <871qlpzebc.fsf@mailbox.org>
Am Donnerstag, dem 16.03.2023 um 01:15 +0000 schrieb Antero Mejr:
> > > + (snippet #~(substitute* "check/examples.frm"
> > > + (("#pend_if valgrind\\?")
> > > + "#pend_if 0")))))
> >
> > This snippet appears to be related to the specifics of this package
> > build? E.g. if someone were to grab the source with `guix build -S
> > form`, they would not be able to have valgrind support, correct?
> > If that's the case, perhaps it would be better to apply this
> > substitution in a build phase.
>
> No, it's disabling a failing test that has a known problem (memory
> leak). Added a comment with the explanation.
Test failures should also be fixed at build time. Other than that, you
could also try to fix the memory leak that causes the failure via a
patch.
> > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.
It does, but not for i386 to i686, which also often see sse2 flags in
build systems.
>
> I used the other homepage so people can skip the weird "license
> agreement" page at https://www.nikhef.nl/~form/.
Calling the GPL a license agreement is weird, and it doesn't help that
https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can
raise an issue about that upstream?
Cheers
next prev parent reply other threads:[~2023-03-16 5:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 1:15 [bug#60266] [PATCH] gnu: Add form Antero Mejr via Guix-patches via
2023-01-09 18:01 ` Eric Bavier
2023-03-16 1:15 ` Antero Mejr via Guix-patches via
2023-03-16 5:23 ` Liliana Marie Prikler [this message]
2023-03-21 18:53 ` Antero Mejr via Guix-patches via
2023-03-22 4:54 ` bug#60266: " Eric Bavier
2023-02-19 22:42 ` [bug#60266] Algebra Andreas Enge
2023-03-16 1:07 ` [bug#60266] [PATCH v2 1/2] gnu: Add form Antero Mejr via Guix-patches via
2023-03-16 1:07 ` [bug#60266] [PATCH v2 2/2] gnu: Add parform Antero Mejr via Guix-patches via
2023-03-21 18:39 ` [bug#60266] [PATCH v3 1/2] gnu: Add form Antero Mejr via Guix-patches via
2023-03-21 18:39 ` [bug#60266] [PATCH v3 2/2] gnu: Add parform Antero Mejr via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=60266@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=bavier@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).