[bug#39108] [PATCH] gnu: Add gst-editing-services.

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

* gnu/packages/gstreamer (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 323e3ccfee..14dbf5a7ed 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -419,6 +419,37 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests with meson, 21 with gnu
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
-- 
2.24.1

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/gstreamer (gst-editing-services): New variable.

Thanks!

[...]
  
> +(define-public gst-editing-services
> +  (package
> +    (name "gst-editing-services")
> +    (version "1.16.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://gstreamer.freedesktop.org/src/" name "/"
> +                    "gstreamer-editing-services-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
> +    (build-system gnu-build-system)

IIRC gstreamer will no longer support gnu-build-system starting with
1.18.  So let's just go straight for Meson here, WDYT?

If you're up for it, it would be good to change the other gstreamer
packages already as well, to make the transition easier.

> +    (arguments
> +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> +     `(#:tests? #f))

When so many tests are failing, it is typically a sign that a dependency
or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you try
to figure out what is causing these failures?

Otherwise LGTM, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

Am Montag, den 13.01.2020, 23:48 +0100 schrieb Marius Bakke:
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
> 
> > * gnu/packages/gstreamer (gst-editing-services): New variable.
> 
> Thanks!
> 
> [...]
>   
> > +(define-public gst-editing-services
> > +  (package
> > +    (name "gst-editing-services")
> > +    (version "1.16.2")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "https://gstreamer.freedesktop.org/src/" name
> > "/"
> > +                    "gstreamer-editing-services-" version
> > ".tar.xz"))
> > +              (sha256
> > +               (base32
> > +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc
> > 1hf"))))
> > +    (build-system gnu-build-system)
> 
> IIRC gstreamer will no longer support gnu-build-system starting with
> 1.18.  So let's just go straight for Meson here, WDYT?
Sure, why not?  It would at least build, though I've "tested" only the
gnu version in terms of actual editing capabilities (some lightweight
clip mixing).

> If you're up for it, it would be good to change the other gstreamer
> packages already as well, to make the transition easier.
> 
> > +    (arguments
> > +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> > +     `(#:tests? #f))
> 
> When so many tests are failing, it is typically a sign that a
> dependency
> or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you
> try
> to figure out what is causing these failures?
Not easily, sadly.  Gstreamer 1.16.2 broke for me in some quite
interesting ways, even outside of packaging, and I have little trust in
my ability to fix it – other than applying some kind of workaround for
my personal use.  (See 39126 for details.)
From what I recall, most of the failing tests are not even failing,
they are erroring, outputting some critical message and a stack trace. 
The problem here is, that you get get critical errors if even just one
element inside a large pipeline behaves badly.  Of course, you can get
the same kind of error, but with a different message, if the plugin
can't even be found.

As far as building gstreamer with meson is concerned, I can look into
it, but the gstreamer package itself has 400 dependants and thus
belongs to staging.  I'm not quite sure whether we can get
implementation + reviews done before the 19th, but let's see what's
possible.

Regards,
Leo

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

I composed a patch in which all of the basic gstreamer stuff (sans
python bindings) are ported to meson.  Perhaps someone might want this
patch to be split, so that each package is modified separately, but I
find that we can treat this as a logical unit as-is.

Of particular note is the disabling of the doc output.  It appears as
if gstreamer really does not know how to build documentation in meson
without the not-yet packaged hotdoc.  However, with there being fewer
dependencies on the plugins rather than gstreamer itself, it should be
possible to port them later.

Finally, I've noticed that gst-plugins-base builds without gl or
wayland support.  Should I add a patch for this or is it fine as-is?

Regards,
Leo

[-- Attachment #2: 0002-gnu-Port-gstreamer-to-meson-build-system.patch --]
[-- Type: text/x-patch, Size: 6379 bytes --]

From 1babfe0decf6cf2029e65c44a6e259851306cb5a Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Wed, 15 Jan 2020 13:05:12 +0100
Subject: [PATCH 2/2] gnu: Port gstreamer to meson-build-system.

* gnu/packages/gstreamer.scm (gstreamer, gst-plugins-good, gst-plugins-bad)
(gst-plugins-ugly, gst-libav, gst-editing-services): Use meson-build-system.
(gstreamer) [arguments]: Drop configure-flags.
Move documentation in post-install phase.
[native-inputs]: Add gtk-doc.
(gst-plugins-base, gst-plugins-bad) [outputs]: Remove doc.
(gst-editing-services) [native-inputs]: Add gst-plugins-good, gst-plugins-bad
and python-pygobject, all of which seem to be required by the build system
only.
---
 gnu/packages/gstreamer.scm | 56 ++++++++++++++++++++++----------------
 1 file changed, 32 insertions(+), 24 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 151d222c68..1f1f632e70 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -116,19 +116,25 @@ arrays of data.")
       (sha256
        (base32
         "0kp93622y29pck8asvil1fmzf55s2gx76wv475a6izc3cwj49w73"))))
-    (build-system gnu-build-system)
+    (build-system meson-build-system)
     (outputs '("out" "doc"))
     (arguments
-     `(#:configure-flags
-       (list (string-append "--with-html-dir="
-                            (assoc-ref %outputs "doc")
-                            "/share/gtk-doc/html"))))
+     `(#:phases
+       (modify-phases %standard-phases
+        (add-after 'install 'move-docs
+         (lambda* (#:key outputs #:allow-other-keys)
+           (mkdir-p (string-append (assoc-ref outputs "doc") "/share"))
+           (rename-file
+            (string-append (assoc-ref outputs "out") "/share/gtk-doc")
+            (string-append (assoc-ref outputs "doc") "/share/gtk-doc"))
+           #t)))))
     (propagated-inputs `(("glib" ,glib))) ; required by gstreamer-1.0.pc.
     (native-inputs
      `(("bison" ,bison)
        ("flex" ,flex)
        ("glib" ,glib "bin")
        ("gobject-introspection" ,gobject-introspection)
+       ("gtk-doc" ,gtk-doc)
        ("perl" ,perl)
        ("pkg-config" ,pkg-config)
        ("python-wrapper" ,python-wrapper)))
@@ -163,8 +169,10 @@ This package provides the core library and elements.")
       (sha256
        (base32
         "0sl1hxlyq46r02k7z70v09vx1gi4rcypqmzra9jid93lzvi76gmi"))))
-    (build-system gnu-build-system)
-    (outputs '("out" "doc"))
+    (build-system meson-build-system)
+    ;; TODO: documentation target is broken in meson
+    ;; future versions rely on hotdoc to be built, which is not yet packaged
+    ;; (outputs '("out" "doc"))
     (propagated-inputs
      `(("glib" ,glib)              ;required by gstreamer-sdp-1.0.pc
        ("gstreamer" ,gstreamer)    ;required by gstreamer-plugins-base-1.0.pc
@@ -199,10 +207,6 @@ This package provides the core library and elements.")
         ("python-wrapper" ,python-wrapper)))
     (arguments
      `(#:parallel-tests? #f ; 'pipelines/tcp' fails in parallel
-       #:configure-flags
-       (list (string-append "--with-html-dir="
-                            (assoc-ref %outputs "doc")
-                            "/share/gtk-doc/html"))
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'patch
@@ -230,7 +234,7 @@ for the GStreamer multimedia library.")
       (sha256
        (base32
         "068k3cbv1yf3gbllfdzqsg263kzwh21y8dpwr0wvgh15vapkpfs0"))))
-    (build-system gnu-build-system)
+    (build-system meson-build-system)
     (inputs
      `(("aalib" ,aalib)
        ("cairo" ,cairo)
@@ -291,14 +295,17 @@ developers consider to have good quality code and correct functionality.")
               (sha256
                (base32
                 "0x0y0hm0ga3zqi5q4090hw5sjh59y1ry9ak16qsaascm72i7mjzi"))))
-    (outputs '("out" "doc"))
-    (build-system gnu-build-system)
+    ;; TODO: upstream currently does not build documentation with meson.
+    ;; (outputs '("out" "doc"))
+    (build-system meson-build-system)
     (arguments
-     '(#:tests? #f ; XXX: 13 of 53 tests fail
-       #:configure-flags
-       (list (string-append "--with-html-dir="
-                            (assoc-ref %outputs "doc")
-                            "/share/gtk-doc/html"))))
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'disable-failing-tests
+           (lambda _
+             (substitute* "tests/check/meson.build"
+               (("\\['elements/dash_mpd.c'\\], not xml2_dep.found\\(\\),")
+                "['elements/dash_mpd.c'], true,")))))))
     (propagated-inputs
      `(("gst-plugins-base" ,gst-plugins-base)))
     (native-inputs
@@ -367,7 +374,7 @@ par compared to the rest.")
        (sha256
         (base32
          "1jpvc32x6q01zjkfgh6gmq6aaikiyfwwnhj7bmvn52syhrdl202m"))))
-    (build-system gnu-build-system)
+    (build-system meson-build-system)
     (inputs
      `(("gst-plugins-base" ,gst-plugins-base)
        ("liba52" ,liba52)
@@ -408,9 +415,7 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
                   ;; Drop bundled ffmpeg.
                   (delete-file-recursively "gst-libs/ext/libav")
                   #t))))
-    (build-system gnu-build-system)
-    (arguments
-     '(#:configure-flags '("--with-system-libav")))
+    (build-system meson-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("python" ,python)))
@@ -438,7 +443,7 @@ compression formats through the use of the libav library.")
               (sha256
                (base32
                 "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
-    (build-system gnu-build-system)
+    (build-system meson-build-system)
     (arguments
      ;; TODO: 16/22 failing tests with meson, 21 with gnu
      `(#:tests? #f))
@@ -447,8 +452,11 @@ compression formats through the use of the libav library.")
        ("libxml2" ,libxml2)))
     (native-inputs
      `(("flex" ,flex)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("gst-plugins-bad" ,gst-plugins-bad)
        ("perl" ,perl)
        ("pkg-config" ,pkg-config)
+       ("python-pygobject" ,python-pygobject)
        ("python" ,python)))
     (home-page "https://gstreamer.freedesktop.org/")
     (synopsis "GStreamer library for non-linear editors")
-- 
2.24.1

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

I've noticed, that staging gstreamer builds with meson now, resolving
this part of the discussion.  I've also noticed some cosmetic errors in
my initial patch, so I'm sending updated versions, one for master and
one for staging (only offsets appear to differ), so that the patch
keeps working after an eventual merge.

Regards,
Leo

[-- Attachment #2: 0001-master-gnu-Add-gst-editing-services.patch --]
[-- Type: text/x-patch, Size: 1903 bytes --]

From 79985310b62219e93ffcc033cddaa6921ceb5182 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 12 Jan 2020 18:42:24 +0100
Subject: [PATCH] gnu: Add gst-editing-services.

* gnu/packages/gstreamer.scm (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 63b4179..151d222 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -426,6 +426,37 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests with meson, 21 with gnu
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
--
libgit2 0.28.4


[-- Attachment #3: 0001-staging-gnu-Add-gst-editing-services.patch --]
[-- Type: text/x-patch, Size: 1903 bytes --]

From 76daab1a0085ef5950cde543e6b41f0559d469c2 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 12 Jan 2020 18:42:24 +0100
Subject: [PATCH] gnu: Add gst-editing-services.

* gnu/packages/gstreamer.scm (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 1e26a3c..85f822d 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -476,6 +476,37 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests with meson, 21 with gnu
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
--
libgit2 0.28.4

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

Am Donnerstag, den 23.01.2020, 13:31 +0100 schrieb Leo Prikler:
> I've noticed, that staging gstreamer builds with meson now, resolving
> this part of the discussion.  I've also noticed some cosmetic errors
> in
> my initial patch, so I'm sending updated versions, one for master and
> one for staging (only offsets appear to differ), so that the patch
> keeps working after an eventual merge.
Just ensuring this is not forgotten.  Since staging is merged now, the
staging patch is the one to apply.

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> I've noticed, that staging gstreamer builds with meson now, resolving
> this part of the discussion.  I've also noticed some cosmetic errors in
> my initial patch, so I'm sending updated versions, one for master and
> one for staging (only offsets appear to differ), so that the patch
> keeps working after an eventual merge.

Oh no, I missed that you had alredy ported GStreamer to the Meson build
system in a previous email!  Sorry for the duplicate work.

I notice in this patch that gst-editing-services still uses
gnu-build-system, can you update it to use meson-build-system instead?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Am Freitag, den 14.02.2020, 16:58 +0100 schrieb Marius Bakke:
> Oh no, I missed that you had alredy ported GStreamer to the Meson
> build
> system in a previous email!  Sorry for the duplicate work.
> 
> I notice in this patch that gst-editing-services still uses
> gnu-build-system, can you update it to use meson-build-system
> instead?
Ahh, my bad.  Updated version is attached.

[-- Attachment #2: 0001-gnu-Add-gst-editing-services.patch --]
[-- Type: text/x-patch, Size: 1881 bytes --]

From b4a43af80e52a63919c3697700f80b73e91bfddb Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 12 Jan 2020 18:42:24 +0100
Subject: [PATCH] gnu: Add gst-editing-services.

* gnu/packages/gstreamer.scm (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 1e26a3c..f33e125 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -476,6 +476,37 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system meson-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
--
libgit2 0.28.4

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> Am Freitag, den 14.02.2020, 16:58 +0100 schrieb Marius Bakke:
>> Oh no, I missed that you had alredy ported GStreamer to the Meson
>> build
>> system in a previous email!  Sorry for the duplicate work.
>> 
>> I notice in this patch that gst-editing-services still uses
>> gnu-build-system, can you update it to use meson-build-system
>> instead?
> Ahh, my bad.  Updated version is attached.

I'm getting a strange build failure with this patch:


...
Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and cmake)

tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig dependency

A full log can be found at /tmp/guix-build-gst-editing-services-1.16.2.drv-0/build/meson-logs/meson-log.txt

I suppose it needs 'gst-plugins-bad'?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#39108] [PATCH] gnu: Add gst-editing-services.

[Leo Prikler]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke:
> I'm getting a strange build failure with this patch:
> 
> 
> ...
> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and
> cmake)
> 
> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig
> dependency
> 
> A full log can be found at /tmp/guix-build-gst-editing-services-
> 1.16.2.drv-0/build/meson-logs/meson-log.txt
> 
> I suppose it needs 'gst-plugins-bad'?
Indeed, it does, though interestingly just for tests, which are
currently broken.  I already had this back when I tried meson, but have
since forgot about it.  There are no actual references to it, so I've
made it a native input.  As far as using it is concerned, I think one
might be able to do without a certain set of plugins depending on the
codecs used.  Either way, I'm not really sure whether it should
propagate the main plugin set.

I also added the good plugins even if they are not mentioned, just to
be on the safe side.  

[-- Attachment #2: 0001-gnu-Add-gst-editing-services.patch --]
[-- Type: text/x-patch, Size: 1975 bytes --]

From f9a9c7dec9681cf7d5d646df96cbbe19f98e5de2 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 12 Jan 2020 18:42:24 +0100
Subject: [PATCH] gnu: Add gst-editing-services.

* gnu/packages/gstreamer.scm (gst-editing-services): New variable.
---
 gnu/packages/gstreamer.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 1e26a3c..0c824e0 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -476,6 +476,39 @@ distribution problems in some jurisdictions, e.g. due to patent threats.")
 compression formats through the use of the libav library.")
     (license license:gpl2+)))
 
+(define-public gst-editing-services
+  (package
+    (name "gst-editing-services")
+    (version "1.16.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://gstreamer.freedesktop.org/src/" name "/"
+                    "gstreamer-editing-services-" version ".tar.xz"))
+              (sha256
+               (base32
+                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
+    (build-system meson-build-system)
+    (arguments
+     ;; TODO: 16/22 failing tests
+     `(#:tests? #f))
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("flex" ,flex)
+       ("gst-plugins-bad" ,gst-plugins-bad)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("python" ,python)))
+    (home-page "https://gstreamer.freedesktop.org/")
+    (synopsis "GStreamer library for non-linear editors")
+    (description
+     "This is a high-level library for facilitating the creation of audio/video
+non-linear editors.")
+    (license license:gpl2+)))
+
 (define-public python-gst
   (package
     (name "python-gst")
--
libgit2 0.28.4

bug#39108: [PATCH] gnu: Add gst-editing-services.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke:
>> I'm getting a strange build failure with this patch:
>> 
>> 
>> ...
>> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
>> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and
>> cmake)
>> 
>> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig
>> dependency
>> 
>> A full log can be found at /tmp/guix-build-gst-editing-services-
>> 1.16.2.drv-0/build/meson-logs/meson-log.txt
>> 
>> I suppose it needs 'gst-plugins-bad'?
> Indeed, it does, though interestingly just for tests, which are
> currently broken.  I already had this back when I tried meson, but have
> since forgot about it.  There are no actual references to it, so I've
> made it a native input.  As far as using it is concerned, I think one
> might be able to do without a certain set of plugins depending on the
> codecs used.  Either way, I'm not really sure whether it should
> propagate the main plugin set.
>
> I also added the good plugins even if they are not mentioned, just to
> be on the safe side.  

OK.  I changed the TODO to a FIXME and added a copyright line for you.

Pushed in 64fc4f3705423c83c680a95d8dea81a39fce9a70, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]