unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 39108-done@debbugs.gnu.org
Subject: bug#39108: [PATCH] gnu: Add gst-editing-services.
Date: Fri, 14 Feb 2020 17:51:07 +0100	[thread overview]
Message-ID: <87mu9l6rk4.fsf@devup.no> (raw)
In-Reply-To: <e8689402a142c424bfe780402d4accb943fc62f6.camel@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke:
>> I'm getting a strange build failure with this patch:
>> 
>> 
>> ...
>> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2
>> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and
>> cmake)
>> 
>> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig
>> dependency
>> 
>> A full log can be found at /tmp/guix-build-gst-editing-services-
>> 1.16.2.drv-0/build/meson-logs/meson-log.txt
>> 
>> I suppose it needs 'gst-plugins-bad'?
> Indeed, it does, though interestingly just for tests, which are
> currently broken.  I already had this back when I tried meson, but have
> since forgot about it.  There are no actual references to it, so I've
> made it a native input.  As far as using it is concerned, I think one
> might be able to do without a certain set of plugins depending on the
> codecs used.  Either way, I'm not really sure whether it should
> propagate the main plugin set.
>
> I also added the good plugins even if they are not mentioned, just to
> be on the safe side.  

OK.  I changed the TODO to a FIXME and added a copyright line for you.

Pushed in 64fc4f3705423c83c680a95d8dea81a39fce9a70, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-02-14 16:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 23:40 [bug#39108] [PATCH] gnu: Add gst-editing-services Leo Prikler
2020-01-13 22:48 ` Marius Bakke
2020-01-14  0:39   ` Leo Prikler
2020-01-15 12:53     ` Leo Prikler
2020-01-23 12:31       ` Leo Prikler
2020-02-11 16:12         ` Leo Prikler
2020-02-14 15:58         ` Marius Bakke
2020-02-14 16:09           ` Leo Prikler
2020-02-14 16:12             ` Marius Bakke
2020-02-14 16:42               ` Leo Prikler
2020-02-14 16:51                 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu9l6rk4.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=39108-done@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).