From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47028)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir8W7-0005R7-LU
 for guix-patches@gnu.org; Mon, 13 Jan 2020 17:49:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir8W6-0007sj-Fh
 for guix-patches@gnu.org; Mon, 13 Jan 2020 17:49:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:54337)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ir8W6-0007sV-8w
 for guix-patches@gnu.org; Mon, 13 Jan 2020 17:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir8W6-0004XL-6o
 for guix-patches@gnu.org; Mon, 13 Jan 2020 17:49:02 -0500
Subject: [bug#39108] [PATCH] gnu: Add gst-editing-services.
Resent-Message-ID: <handler.39108.B39108.157895571017402@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20200112234026.12266-1-leo.prikler@student.tugraz.at>
References: <20200112234026.12266-1-leo.prikler@student.tugraz.at>
Date: Mon, 13 Jan 2020 23:48:18 +0100
Message-ID: <874kwzvuq5.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 39108@debbugs.gnu.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/gstreamer (gst-editing-services): New variable.

Thanks!

[...]
=20=20
> +(define-public gst-editing-services
> +  (package
> +    (name "gst-editing-services")
> +    (version "1.16.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://gstreamer.freedesktop.org/src/" name "/"
> +                    "gstreamer-editing-services-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))=
))
> +    (build-system gnu-build-system)

IIRC gstreamer will no longer support gnu-build-system starting with
1.18.  So let's just go straight for Meson here, WDYT?

If you're up for it, it would be good to change the other gstreamer
packages already as well, to make the transition easier.

> +    (arguments
> +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> +     `(#:tests? #f))

When so many tests are failing, it is typically a sign that a dependency
or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you try
to figure out what is causing these failures?

Otherwise LGTM, thanks!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4c87IACgkQoqBt8qM6
VPrOzAgAnzonwAH4ewazQBK09VByTxpLk7eEY2nGcd/A+loxHBuQrgVDI/oVRFMG
tNwD0NVyYIJMI3WdObKtP3UK/uE7YWS+zK6MPnqEG34Vd53fjOcs2OjMcI1OR/z5
4H1Ug1u9/PBg5CgTygDVHJJABZpvqxkFdzt8GqtwKdlIhXyTYuokiYQhQeFSxe36
BJT1l6J3fpATLwuyiUTlTbjvRSbaxSguFmzfZOWwTL2K4h44ZUsbap+HW8f3GolC
/t7Xulu1UvfU2ECTejwaAA4JToBVfqxTJmAnJNcdYaawkIQyxDEuAUKTv88kEn4o
r2woJrFU4tYLPuhFk433AIa1omcLyQ==
=BOiP
-----END PGP SIGNATURE-----
--=-=-=--