From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Simon Tournier" <zimon.toutoune@gmail.com>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: $EDITOR and “guix edit”
Date: Mon, 20 Nov 2023 20:33:51 +0100 [thread overview]
Message-ID: <e7074f18e1f1fd54da4d8500b002065140ce564f.camel@gmail.com> (raw)
In-Reply-To: <86h6lg3gq0.fsf@gmail.com>
Am Montag, dem 20.11.2023 um 10:40 +0100 schrieb Simon Tournier:
> Hi,
>
> On Thu, 16 Nov 2023 at 17:04, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
>
> > > It’d be nice to support these as well. However, how do we know
> > > we’re dealing with kate or VSCode? By checking the basename of
> > > $EDITOR? Kinda ugly and brittle, but probably better than
> > > nothing.
> >
> > Maybe we can check for a guix_editor shell function and invoke that
> > rather than EDITOR if defined?
>
> Yeah, from my point of view, the two alternatives [1] are:
>
> 1. do we tweak “guix edit” for behaving differently depending on
> $EDITOR?
>
> or
>
> 2. do we provide some wrappers for the issues that already popped
> up?
>
> Where #1 is what Ludo suggests and #2 is what Liliana suggests. :-)
>
> Well, see below the code [2] that we concretely need for VSCode. The
> question is:
>
> 1. Do we put this code in guix/scripts/edit.scm? And trigger on the
> basename of EDITOR?
>
> or
>
> 2. Do we put this code in some etc/vscode-wrapper that user can
> install? (or that we could automatically installl) Or maybe revamp
> it
> for calling this code via some shell function?
With VSCode et al. not being Guix packages, I see little point in
providing these wrappers through Guix itself. With kate we could at
least install a "kate-for-guix-edit" wrapper through the package or
something.
Cheers
next prev parent reply other threads:[~2023-11-20 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 9:43 $EDITOR and “guix edit” Simon Tournier
2023-11-02 10:24 ` Liliana Marie Prikler
2023-11-16 15:25 ` Ludovic Courtès
2023-11-16 16:04 ` Liliana Marie Prikler
2023-11-20 9:40 ` Simon Tournier
2023-11-20 19:33 ` Liliana Marie Prikler [this message]
2024-01-12 9:35 ` Simon Tournier
2024-01-12 17:39 ` Liliana Marie Prikler
2024-01-12 18:49 ` Simon Tournier
2024-01-12 19:46 ` Liliana Marie Prikler
2024-01-12 21:27 ` Simon Tournier
2023-11-22 18:21 ` Ludovic Courtès
2023-11-22 19:24 ` Liliana Marie Prikler
2023-12-09 9:24 ` Ludovic Courtès
2023-12-09 9:55 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7074f18e1f1fd54da4d8500b002065140ce564f.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).