unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>, "Guix Devel" <guix-devel@gnu.org>
Subject: Re: $EDITOR and “guix edit”
Date: Fri, 12 Jan 2024 20:46:06 +0100	[thread overview]
Message-ID: <2121d86481580e3a399e1d0d27d9b94602e1ac3b.camel@gmail.com> (raw)
In-Reply-To: <CAJ3okZ1gMU1SDWpLvQt+M88K5BmZe2T4yXtgfpfxANdqLQ3CQg@mail.gmail.com>

Am Freitag, dem 12.01.2024 um 19:49 +0100 schrieb Simon Tournier:
> Hi,
> 
> On Fri, 12 Jan 2024 at 18:39, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
> 
> > > Well, I see how to write specific Scheme wrapper around $EDITOR;
> > > as I did in [1].
> > > 
> > > Or, I see how to tweak guix/scripts/edit.scm for running specific
> > > launcher depending on $EDITOR.
> > > 
> > > Liliana, could you provide a proof-of-concept about « the shell-
> > > esque "${LINE}" and "${FILE}" that would get replaced by Scheme
> > > code looking for those strings »?  Because I do not see what you
> > > mean.
> > 
> > (let* ((editor (getenv "GUIX_EDITOR"))
> >        (editor (string-replace-substring editor "${FILE}" the-
> > file))
> >        (editor (string-replace-substring editor "${LINE}" the-
> > line)))
> >   editor)
> > 
> > with the-file and the-line being placeholders for the actual
> > variable names.  You could obviously do smarter things with gash,
> > but let's not go there at the moment.
> 
> I do not understand how it is different from the wrapper I already
> did:
> 
> https://gitlab.com/zimoun/advanced-packages-2023/-/blob/main/vscode-wrapper?ref_type=heads#L70-99
Look at your wrapper, than back at my suggestion, then back at your
wrapper, then back at my suggestion.  Somehow, your wrapper isn't my
suggestion.  Instead, my suggestion is something else entirely, that
doesn't even mention the M$ editor.  Curious how that works.

Cheers

PS: I should probably just write the patch myself at this point, but I
feel like it'll be misunderstood either way.


  reply	other threads:[~2024-01-12 19:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  9:43 $EDITOR and “guix edit” Simon Tournier
2023-11-02 10:24 ` Liliana Marie Prikler
2023-11-16 15:25   ` Ludovic Courtès
2023-11-16 16:04     ` Liliana Marie Prikler
2023-11-20  9:40       ` Simon Tournier
2023-11-20 19:33         ` Liliana Marie Prikler
2024-01-12  9:35           ` Simon Tournier
2024-01-12 17:39             ` Liliana Marie Prikler
2024-01-12 18:49               ` Simon Tournier
2024-01-12 19:46                 ` Liliana Marie Prikler [this message]
2024-01-12 21:27                   ` Simon Tournier
2023-11-22 18:21       ` Ludovic Courtès
2023-11-22 19:24         ` Liliana Marie Prikler
2023-12-09  9:24           ` Ludovic Courtès
2023-12-09  9:55             ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2121d86481580e3a399e1d0d27d9b94602e1ac3b.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).