unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	Guix Devel <guix-devel@gnu.org>
Subject: Re: $EDITOR and “guix edit”
Date: Wed, 22 Nov 2023 20:24:59 +0100	[thread overview]
Message-ID: <772cbd0d5228b5754e71a8ad999aa755b4949526.camel@gmail.com> (raw)
In-Reply-To: <87r0khir8y.fsf@gnu.org>

Am Mittwoch, dem 22.11.2023 um 19:21 +0100 schrieb Ludovic Courtès:
> Hello,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> 
> > Am Donnerstag, dem 16.11.2023 um 16:25 +0100 schrieb Ludovic
> > Courtès:
> 
> [...]
> 
> > > It’d be nice to support these as well.  However, how do we know
> > > we’re
> > > dealing with kate or VSCode?  By checking the basename of
> > > $EDITOR?
> > > Kinda ugly and brittle, but probably better than nothing.
> > Maybe we can check for a guix_editor shell function and invoke that
> > rather than EDITOR if defined?
> 
> ‘guix edit’ cannot “invoke” a shell function though.
> 
> I was thinking of something more gross, like checking whether the
> basename of $EDITOR is ‘kate’ or ‘vscode’ and in that case do
> whatever is relevant for those editors.
> 
> WDYT?
I see your gross "checking whether the basename of $EDITOR is ‘kate’…"
and I raise my "use $GUIX_EDITOR which uses substring replacements for
${LINE} and ${FILE} implemented in pure Guile code"

Cheers


  reply	other threads:[~2023-11-22 19:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  9:43 $EDITOR and “guix edit” Simon Tournier
2023-11-02 10:24 ` Liliana Marie Prikler
2023-11-16 15:25   ` Ludovic Courtès
2023-11-16 16:04     ` Liliana Marie Prikler
2023-11-20  9:40       ` Simon Tournier
2023-11-20 19:33         ` Liliana Marie Prikler
2024-01-12  9:35           ` Simon Tournier
2024-01-12 17:39             ` Liliana Marie Prikler
2024-01-12 18:49               ` Simon Tournier
2024-01-12 19:46                 ` Liliana Marie Prikler
2024-01-12 21:27                   ` Simon Tournier
2023-11-22 18:21       ` Ludovic Courtès
2023-11-22 19:24         ` Liliana Marie Prikler [this message]
2023-12-09  9:24           ` Ludovic Courtès
2023-12-09  9:55             ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=772cbd0d5228b5754e71a8ad999aa755b4949526.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).