From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0C0zLtq0W2UtGgAA9RJhRA:P1 (envelope-from ) for ; Mon, 20 Nov 2023 20:34:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0C0zLtq0W2UtGgAA9RJhRA (envelope-from ) for ; Mon, 20 Nov 2023 20:34:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C2825F45F for ; Mon, 20 Nov 2023 20:34:50 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N5lLezTx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700508890; a=rsa-sha256; cv=none; b=j+wjqcol8BL1OqYArxzZzV8xQG+K/VUQdzcRp2L6qgVgm71lJm39XCgVbbK6rxAsXhLzle Kx2Gy8qB57l3TWrEqV8x5jHO1eYn+4+6Pj0z61CW+LpetoaiTl7lzG986Tl4VPL1SO83Wg AlJyTzMEMxnxwFR5J+oqozIaOgL8+2s47c/COVw7CudD1XLD9G3MXrk+bc375lxGUPrfD+ eYE0YI46YiYxo5PJwrgk+zCHzHkIf/4QWkiSjOMDpOV2iep6uRx+mLC7c3TEXdsXkNBrkb DoaVgr9ZHW2zkHJHOe2/AIHAYJcyR3M1Fe0MN3JlcYBmaxsrjbv+Krm1iqZalw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N5lLezTx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700508890; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=frx5ZIxuuy06RzZxenn84Yg4Za7VBhpsnysj7bfHqJ8=; b=dCZitaGvOizIFgEPmNvrkrPqEF1aH+Uo+9f3vHHdVbU3net1IXtGXukG9poyVp/7sVOkt8 Yksim4FwXwA5JtRVjYVYstTozYR5lljkHD4XHyddz+SAm4Gmme7y+gAYY+PX61dg5YrWzi JL9pcnFoC+auwSHHWEz0iHTo3SGo7qqYPhHKuXH5hIV9b/A8GR46y+nlolXOk7FimEllXf upjXAUVjKUXIo9DLl1iwkXOsWCehfcoz2Ete1MjLgzMNaYaOvyN0n8ucDx0zoj1K7DrcJj cCLUulK4jo1og1XKyoNcd9rhUiAJQsbVuZ2cTax9hDEiexkxuFAo8HWI08YMQw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5A20-0000Ft-JV; Mon, 20 Nov 2023 14:34:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5A1x-0000F1-9T for guix-devel@gnu.org; Mon, 20 Nov 2023 14:34:02 -0500 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5A1v-0007qr-Hl; Mon, 20 Nov 2023 14:34:01 -0500 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-a00ac0101d9so84816466b.0; Mon, 20 Nov 2023 11:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700508834; x=1701113634; darn=gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=frx5ZIxuuy06RzZxenn84Yg4Za7VBhpsnysj7bfHqJ8=; b=N5lLezTx9j3fvEj7sj0GU67TYmeIia2CALRu8qOgHbj+AScVrW1Xr61rHvItAkFLV4 qUHnFgOXw5wmZCxjMjMa7UPE6u+FQtIRQOqCYXQugGCX9YpQdIKc+ABZ46PtzsOQIasg +FW3foF6fDSSqqZiF9jTghOAKuSwpuF2/+RjpzKP+EXxI4LV9LbI/aYUZvYddpCAr1fu LGTYM4tVUo5qymHQMWmtkFS5LgeW3ntA3pQb4MR6mp48NyaCTEvAadypsr/S9fvg++08 PQblVIN56SJCb5KjIuZuNbzvIvUKIdY3y9/8+hVA677zCHMnX6jCcN8D3PzHmOc1RIp7 7V1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700508834; x=1701113634; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=frx5ZIxuuy06RzZxenn84Yg4Za7VBhpsnysj7bfHqJ8=; b=Honwgq9rmICVD9BFHDvPfBdixHlKkb0Gyqi4XnFatNw3vsGlt4CU1c/wlyNze1QcDL B+poZWZ3Y5+klfSq120/iqAz+cylUf0aQGoWciwARSGuwnOV7dWQ0J57AmKPTibeFaiv dDMDjK3EOPOOOvnLrmJyy7s5b8MQHfIYqe08YgaQ9G/F9bka6vtkjTZ8UEgGoL+pd8Mp uUR3qek5JRaAYDu2SG0HHPmwbcV7x0d1/sO0FzeAcDXSYC5dSvIVZ/Hv6jOmzGHIiPCz EPyNYVXSanJNQrm17hGENRkVL17YYAMFkvlAEg92Yw8NCYOQli+sXVTMu5rWsZ0Ejgpc io4g== X-Gm-Message-State: AOJu0Yxy/J2viyejVdzwnHZGne/3rFrRbxiMotqHz4xZKXA3WvaN/A7s WBHqIPfxveg5iXXXVXpPp/U= X-Google-Smtp-Source: AGHT+IEtEHZpY36J29y9LnqqYRcPmt1DORk0jya5Bdto8JwyToEkSBK2lbI9evw+fbRRXNKErWZI5Q== X-Received: by 2002:a17:906:32d3:b0:9a6:426f:7dfd with SMTP id k19-20020a17090632d300b009a6426f7dfdmr5590850ejk.66.1700508833346; Mon, 20 Nov 2023 11:33:53 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d2-20020a170906640200b0099bd7b26639sm4187726ejm.6.2023.11.20.11.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 11:33:52 -0800 (PST) Message-ID: Subject: Re: $EDITOR and =?UTF-8?Q?=E2=80=9Cguix?= =?UTF-8?Q?_edit=E2=80=9D?= From: Liliana Marie Prikler To: Simon Tournier , Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: Guix Devel Date: Mon, 20 Nov 2023 20:33:51 +0100 In-Reply-To: <86h6lg3gq0.fsf@gmail.com> References: <86wmv0o5gi.fsf@gmail.com> <416a6472edf6d2123c47ea5b555bedd005f6ac6f.camel@gmail.com> <87r0kpu3d9.fsf@gnu.org> <246521d6a06ee6954372278b8507c346fcc068cb.camel@gmail.com> <86h6lg3gq0.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=liliana.prikler@gmail.com; helo=mail-ej1-x643.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 9C2825F45F X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.28 X-Spam-Score: -8.28 X-TUID: lmVyWUXsAIA3 Am Montag, dem 20.11.2023 um 10:40 +0100 schrieb Simon Tournier: > Hi, >=20 > On Thu, 16 Nov 2023 at 17:04, Liliana Marie Prikler > wrote: >=20 > > > It=E2=80=99d be nice to support these as well.=C2=A0 However, how do = we know > > > we=E2=80=99re dealing with kate or VSCode?=C2=A0 By checking the base= name of > > > $EDITOR? Kinda ugly and brittle, but probably better than > > > nothing. > >=20 > > Maybe we can check for a guix_editor shell function and invoke that > > rather than EDITOR if defined? >=20 > Yeah, from my point of view, the two alternatives [1] are: >=20 > =C2=A0 1. do we tweak =E2=80=9Cguix edit=E2=80=9D for behaving differentl= y depending on > $EDITOR? >=20 > or >=20 > =C2=A0 2. do we provide some wrappers for the issues that already popped > up? >=20 > Where #1 is what Ludo suggests and #2 is what Liliana suggests. :-) >=20 > Well, see below the code [2] that we concretely need for VSCode.=C2=A0 Th= e > question is: >=20 > =C2=A01. Do we put this code in guix/scripts/edit.scm?=C2=A0 And trigger = on the > =C2=A0basename of EDITOR? >=20 > or >=20 > =C2=A02. Do we put this code in some etc/vscode-wrapper that user can > =C2=A0install?=C2=A0 (or that we could automatically installl) Or maybe r= evamp > it > =C2=A0for calling this code via some shell function? With VSCode et al. not being Guix packages, I see little point in providing these wrappers through Guix itself. With kate we could at least install a "kate-for-guix-edit" wrapper through the package or something. Cheers