unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>, guix-devel@gnu.org
Subject: Re: Autotools-generated 'configure' & 'Makefile.in' considered binaries?
Date: Wed, 30 Mar 2022 20:55:20 +0200	[thread overview]
Message-ID: <df0abbb256354eaa31a7e63ef2c60595e623b64a.camel@gmail.com> (raw)
In-Reply-To: <9c2ca57d59672fc4f9ebc0230b08d8953030a456.camel@telenet.be>

Am Mittwoch, dem 30.03.2022 um 14:04 +0200 schrieb Maxime Devos:
> Hi guix,
> 
> Quite some packages in Guix use the Autotools system.  In this
> system, a 'configure.ac' and 'Makefile.am' script / makefile is
> written, from which 'autoconf' & 'automake' generate a very long bash
> script and a Makefile.in.  Depending on the maintainer of the
> upstream package, this 'configure' and 'Makefile.in' are sometimes
> included in release tarballs.
> 
> This seems in conflict with:
> 
>   * (guix)Submitting patches: ‘Make sure the package does not use
>     bundled copies of software already available as separate
>     packages.’
> 
>     Autotools packages have a 'config.guess' and 'config.sub' script
>     that need to be updated whenever there's a new architecture.  As
>     such, for some packages, these need to be replaced for aarch64,
>     powerpc or risv64.  There are also some packages with very old
>     configure scripts that don't support --build/--host/--target,
>     which could gain --build/--host/--target support by just
>     regenerating them.
> 
>     This also makes ensuring a package does not contain any malware
>     much harder, because the configure script (and related files)
>     needs to be read in their entirity.
> 
>  * When an upstream tarball contains .so, .dll, .a, etc. binaries,
>    they are removed downstream in a snippet.  Why would the Autotools
>    be an exception?
Note that many autotools-based packages already require the addition of
autoconf and friends due to being pulled from git.  That being said,
it's somewhat hard to argue for completely dropping them, because
a. simply matching files via ".in" suffix would be error-prone
b. autoreconf should regenerate these files regardless
Therefore, my counter-proposal would be to just simply always run the
bootstrap script or autoreconf, even if the respective files are
tarballed, as well as adding autoconf and automake to the implicit
native inputs of gnu build system.

> For some ‘early’ packages (gcc, glibc, binutils, ...), there's a
> circularity problem
The obvious solution to which would be to implement m4 in mes :)

> [B]uilding 'configure' and 'Makefile.in' from source might not always
> be possible, but WDYT of building 'configure' & 'Makefile.in' from
> source for packages where it does not result in bootstrapping
> problems?
See above, but to reiterate, I'm generally in favor.

Regarding tooling support, I think autotools should have an option to
build a non-bootstrapped dist tarball.  If more upstreams produced such
stripped tarballs, we wouldn't even be having that debate.

Cheers


  parent reply	other threads:[~2022-03-30 19:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 12:04 Autotools-generated 'configure' & 'Makefile.in' considered binaries? Maxime Devos
2022-03-30 14:31 ` Zhu Zihao
2022-03-31 11:17   ` Maxime Devos
2022-03-31 11:19   ` Maxime Devos
2022-03-31 11:22   ` Maxime Devos
2022-03-31 11:27   ` Maxime Devos
2022-03-30 18:55 ` Liliana Marie Prikler [this message]
2022-03-30 19:24   ` Maxime Devos
2022-03-31  4:22     ` Liliana Marie Prikler
2022-03-31 11:10       ` Maxime Devos
2022-03-31 18:24         ` Liliana Marie Prikler
2022-03-31 18:31           ` Maxime Devos
2022-03-31 20:11             ` Liliana Marie Prikler
2022-04-01  8:58 ` Ludovic Courtès
2022-04-01 10:03   ` Maxime Devos
2022-04-05 12:06     ` Ludovic Courtès
2022-04-06 16:35       ` Maxim Cournoyer
2022-04-10 20:25         ` Ludovic Courtès
2022-05-02 10:55       ` zimoun
2022-04-01  9:12 ` Jonathan McHugh
  -- strict thread matches above, loose matches on Subject: below --
2022-06-29 19:01 Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df0abbb256354eaa31a7e63ef2c60595e623b64a.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).