From: Andreas Enge <andreas@enge.fr>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: "Maxim Cournoyer" <maxim.cournoyer@gmail.com>,
宋文武 <iyzsong@envs.net>, "Ludovic Courtès" <ludo@gnu.org>,
"Christopher Baines" <mail@cbaines.net>,
guix-devel@gnu.org, 61894@debbugs.gnu.org,
guix-maintainers@gnu.org
Subject: Re: bug#61894: [PATCH RFC] Team approval for patches
Date: Sat, 11 Mar 2023 00:19:01 +0100 [thread overview]
Message-ID: <ZAu65VR4Nxo7Efys@jurong> (raw)
In-Reply-To: <87ilf8mry1.fsf@gmail.com>
Am Fri, Mar 10, 2023 at 06:33:58PM +0100 schrieb Simon Tournier:
> However, for some packages or changes, the impact is far from being
> trivial. I have in mind many changes that happen aside gnu/packages and
> also some core packages (Guile, etc.).
> For these kind of changes, it does not appear to me so crazy to ask more
> than the submitter or committer eyes.
That is true! So far, this has been handled by common sense of the people
working on a patch (and sometimes that process then fails).
> (b) that some implicit that worked until now needs to be more explicit.
> And (b) does not mean strong all white or all black.
In the longer run I also agree with (b). But I am not sure it will be easy
to formulate a rule that captures well the intended policy and draws the
line between "trivial", anybody can push any time, and "complex", where more
opinions are needed, and maybe stages in between. It may be worth the trial.
Andreas
next prev parent reply other threads:[~2023-03-10 23:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 16:13 [bug#61894] [PATCH RFC] Team approval for patches Ludovic Courtès
2023-03-01 17:15 ` Christopher Baines
2023-03-01 17:59 ` Björn Höfling
2023-03-01 18:17 ` Christopher Baines
2023-03-01 19:21 ` Felix Lechner via Guix-patches via
2023-03-01 22:45 ` Ludovic Courtès
2023-03-02 11:04 ` Andreas Enge
2023-03-02 13:57 ` bug#61894: " bokr
2023-03-03 1:08 ` 宋文武
2023-03-07 1:53 ` [bug#61894] " 宋文武 via Guix-patches via
2023-03-07 10:36 ` bug#61894: " Andreas Enge
2023-03-07 12:22 ` Simon Tournier
2023-03-07 18:29 ` [bug#61894] " Maxim Cournoyer
2023-03-07 22:40 ` Leo Famulari
2023-03-08 18:58 ` bug#61894: " Maxim Cournoyer
2023-03-09 8:48 ` [bug#61894] " Simon Tournier
2023-03-08 9:12 ` bug#61894: " Efraim Flashner
2023-03-08 17:05 ` Maxim Cournoyer
2023-03-08 23:38 ` Vagrant Cascadian
2023-03-09 5:12 ` Maxim Cournoyer
2023-03-09 9:46 ` Simon Tournier
2023-03-10 4:36 ` Maxim Cournoyer
2023-03-10 17:22 ` Ludovic Courtès
2023-03-10 18:22 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-03-12 2:33 ` Maxim Cournoyer
2023-03-12 11:14 ` Simon Tournier
2023-03-12 3:26 ` Maxim Cournoyer
2023-03-12 11:52 ` Andreas Enge
2023-03-13 0:08 ` Maxim Cournoyer
2023-03-12 12:25 ` Simon Tournier
2023-03-15 16:08 ` Ludovic Courtès
2023-03-17 15:46 ` [bug#61894] " Maxim Cournoyer
2023-03-10 14:19 ` bug#61894: " Andreas Enge
2023-03-10 17:33 ` Simon Tournier
2023-03-10 23:19 ` Andreas Enge [this message]
2023-03-11 13:20 ` Simon Tournier
2023-03-07 15:21 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-03-06 15:48 ` [bug#61894] " Maxim Cournoyer
2023-03-06 21:42 ` Ludovic Courtès
2023-06-02 13:50 ` bug#61894: " Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2023-03-13 16:30 Peter Polidoro
2023-03-14 15:58 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAu65VR4Nxo7Efys@jurong \
--to=andreas@enge.fr \
--cc=61894@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=guix-maintainers@gnu.org \
--cc=iyzsong@envs.net \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=maxim.cournoyer@gmail.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).