From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AATUIga7C2QrOAEASxT56A (envelope-from ) for ; Sat, 11 Mar 2023 00:19:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cLT/IQa7C2QSGgAAG6o9tA (envelope-from ) for ; Sat, 11 Mar 2023 00:19:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58FB83FDEE for ; Sat, 11 Mar 2023 00:19:33 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678490373; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=eJdJzzSf4mWIpeawdMGoF6xSG7UPhgjLwZMVn/f1dfQ=; b=mc6dYVxMRV9jEZjgFgFqGrRuzLUDRRsqK8Mvix1ertfWEiJZvzRI+rzZO+FEO2ANgchZpQ b2jHWz372H0TaaiB49j1j69vYbPa4JIEO/cTvpnEulPalGVQySzC1gdxIorQ4UaWdP8nmt QhWNufSViQRlPI6Dg9cynJXYqO51dPoFeE557jVw4dre6btTdp40TPb5tzIWnRHE8uJAf3 8Sv8fktk/5Iyuc90gf3B3SJzgEucdhQXGuionDcKJgu7MQA5C/putA58Om4tCCV14VziOc hejvk/zZxAQ6xfDk3kpMP6pD+zT5G5VHEy3sCnAbC+PdoccAXkyxBfHKT2BnMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678490373; a=rsa-sha256; cv=none; b=NWCoGjPySVvxozSEHepFmftzJWnkDJz7eeBlVD+RmQzS3mSzyO+ICzNR4Ms3mR9itBjuI0 BESnxahsvgnQq/F1viMI0wOXoONookWV55S96JhsCeAzSGh33Wa9hIOqEF1Cie6IPBPxLR HxlLITphW8tULKKuvFHxpjG90HEYLMHgZrs/g2tUQJVa6ZAo/1Jf52g8pYV8b9bI6WsbE1 kyd91d+QKYAmNvpxvymEpTvRxVlyDHIUYJDD1PsFz6LQ3q8rSJvsGTI1AzG3pSTQ4pfJ53 c4JI/FzhadsvuS4hTQTK7jqLRB5LJcIdI683010/+PPAwoeH45e7DXN3XD5URw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pam11-0001qm-My; Fri, 10 Mar 2023 18:19:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pam0z-0001qP-Vm for guix-devel@gnu.org; Fri, 10 Mar 2023 18:19:10 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pam0x-0001f4-IL; Fri, 10 Mar 2023 18:19:09 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E70E617EF; Sat, 11 Mar 2023 00:19:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n03ihUzfCyJr; Sat, 11 Mar 2023 00:19:03 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1F87C35E; Sat, 11 Mar 2023 00:19:03 +0100 (CET) Date: Sat, 11 Mar 2023 00:19:01 +0100 From: Andreas Enge To: Simon Tournier Cc: Maxim Cournoyer , =?utf-8?B?5a6L5paH5q2m?= , Ludovic =?iso-8859-15?Q?Court=E8s?= , Christopher Baines , guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org Subject: Re: bug#61894: [PATCH RFC] Team approval for patches Message-ID: References: <87r0u86qgo.fsf_-_@gnu.org> <87y1o9mina.fsf_-_@envs.net> <861qm0da4y.fsf@gmail.com> <87sfegwh28.fsf@gmail.com> <878rg7uqb4.fsf@gmail.com> <86lek6ntpb.fsf@gmail.com> <87ilf8mry1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ilf8mry1.fsf@gmail.com> Received-SPF: pass client-ip=185.233.100.1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 58FB83FDEE X-Spam-Score: 0.20 X-Migadu-Spam-Score: 0.20 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: fcRxH+88HIFn Am Fri, Mar 10, 2023 at 06:33:58PM +0100 schrieb Simon Tournier: > However, for some packages or changes, the impact is far from being > trivial. I have in mind many changes that happen aside gnu/packages and > also some core packages (Guile, etc.). > For these kind of changes, it does not appear to me so crazy to ask more > than the submitter or committer eyes. That is true! So far, this has been handled by common sense of the people working on a patch (and sometimes that process then fails). > (b) that some implicit that worked until now needs to be more explicit. > And (b) does not mean strong all white or all black. In the longer run I also agree with (b). But I am not sure it will be easy to formulate a rule that captures well the intended policy and draws the line between "trivial", anybody can push any time, and "complex", where more opinions are needed, and maybe stages in between. It may be worth the trial. Andreas