* [PATCH] Propagate input for JACK; fix portaudio JACK-support
@ 2015-07-18 20:16 Ricardo Wurmus
2015-07-19 21:05 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Wurmus @ 2015-07-18 20:16 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
Hi Guix,
while packaging Extempora I noticed that the portaudio does not seem to
work with JACK. Extempora uses portaudio and it would not create a JACK
port.
After I rebuilt portaudio with “jack-1” rather than “jack-2” Extempora
would create a JACK port via portaudio successfully. “jack-1” had to be
modified to propagate “bdb” because the libjack headers include it.
Attached are these two patches.
In general I would suggest only to use “jack-1” as an input. “jack-2”
is a different implementation, but it does not replace “jack-1”.
For a user it may make sense to install “jack-2” because of DBus
support, but for libraries it should not be needed.
~~ Ricardo
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-jack-1-Propagate-bdb.patch --]
[-- Type: text/x-patch, Size: 1110 bytes --]
From 579dcf04e35a093ca6bb97efff5aaec19053c080 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sat, 18 Jul 2015 22:07:45 +0200
Subject: [PATCH 1/2] gnu: jack-1: Propagate "bdb".
* gnu/packages/audio.scm (jack-1)[inputs]: Move "bdb" from here...
[propagated-inputs]: ...to here.
---
gnu/packages/audio.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index ff6fb46..0fa506b 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -667,11 +667,12 @@ especially for creating reverb effects. It supports impulse responses with 1,
(build-system gnu-build-system)
(inputs
`(("alsa-lib" ,alsa-lib)
- ("bdb" ,bdb)
("readline" ,readline)))
;; uuid.h is included in the JACK type headers
+ ;; db.h is included in the libjack metadata headers
(propagated-inputs
- `(("libuuid" ,util-linux)))
+ `(("libuuid" ,util-linux)
+ ("bdb" ,bdb)))
(native-inputs
`(("pkg-config" ,pkg-config)))
(home-page "http://jackaudio.org/")
--
2.4.3
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-portaudio-Build-with-jack-1.patch --]
[-- Type: text/x-patch, Size: 778 bytes --]
From 4238c7742fef8e7786569beefe79ca9188b50e8e Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sat, 18 Jul 2015 22:09:13 +0200
Subject: [PATCH 2/2] gnu: portaudio: Build with jack-1.
* gnu/packages/audio.scm (portaudio)[inputs]: Replace "jack-2" with "jack-1".
---
gnu/packages/audio.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0fa506b..c8fcab1 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1583,7 +1583,7 @@ portions of LAME.")
(inputs
;; TODO: Add ASIHPI.
`(("alsa-lib" ,alsa-lib)
- ("jack" ,jack-2)))
+ ("jack" ,jack-1)))
(native-inputs
`(("autoconf" ,autoconf)
("automake" ,automake)
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Propagate input for JACK; fix portaudio JACK-support
2015-07-18 20:16 [PATCH] Propagate input for JACK; fix portaudio JACK-support Ricardo Wurmus
@ 2015-07-19 21:05 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-07-19 21:05 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <rekado@elephly.net> skribis:
> while packaging Extempora I noticed that the portaudio does not seem to
> work with JACK. Extempora uses portaudio and it would not create a JACK
> port.
>
> After I rebuilt portaudio with “jack-1” rather than “jack-2” Extempora
> would create a JACK port via portaudio successfully. “jack-1” had to be
> modified to propagate “bdb” because the libjack headers include it.
>
> Attached are these two patches.
Makes sense.
> In general I would suggest only to use “jack-1” as an input. “jack-2”
> is a different implementation, but it does not replace “jack-1”.
> For a user it may make sense to install “jack-2” because of DBus
> support, but for libraries it should not be needed.
OK.
> From 579dcf04e35a093ca6bb97efff5aaec19053c080 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:07:45 +0200
> Subject: [PATCH 1/2] gnu: jack-1: Propagate "bdb".
>
> * gnu/packages/audio.scm (jack-1)[inputs]: Move "bdb" from here...
> [propagated-inputs]: ...to here.
LGTM.
> From 4238c7742fef8e7786569beefe79ca9188b50e8e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:09:13 +0200
> Subject: [PATCH 2/2] gnu: portaudio: Build with jack-1.
>
> * gnu/packages/audio.scm (portaudio)[inputs]: Replace "jack-2" with "jack-1".
LGTM. Perhaps a comment should be added next to this package or next to
‘jack-2’ to explain what you wrote above?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-19 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-18 20:16 [PATCH] Propagate input for JACK; fix portaudio JACK-support Ricardo Wurmus
2015-07-19 21:05 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).