From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Propagate input for JACK; fix portaudio JACK-support
Date: Sun, 19 Jul 2015 23:05:16 +0200 [thread overview]
Message-ID: <87y4ibkgdv.fsf@gnu.org> (raw)
In-Reply-To: <874ml1fch0.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 18 Jul 2015 22:16:27 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> while packaging Extempora I noticed that the portaudio does not seem to
> work with JACK. Extempora uses portaudio and it would not create a JACK
> port.
>
> After I rebuilt portaudio with “jack-1” rather than “jack-2” Extempora
> would create a JACK port via portaudio successfully. “jack-1” had to be
> modified to propagate “bdb” because the libjack headers include it.
>
> Attached are these two patches.
Makes sense.
> In general I would suggest only to use “jack-1” as an input. “jack-2”
> is a different implementation, but it does not replace “jack-1”.
> For a user it may make sense to install “jack-2” because of DBus
> support, but for libraries it should not be needed.
OK.
> From 579dcf04e35a093ca6bb97efff5aaec19053c080 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:07:45 +0200
> Subject: [PATCH 1/2] gnu: jack-1: Propagate "bdb".
>
> * gnu/packages/audio.scm (jack-1)[inputs]: Move "bdb" from here...
> [propagated-inputs]: ...to here.
LGTM.
> From 4238c7742fef8e7786569beefe79ca9188b50e8e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:09:13 +0200
> Subject: [PATCH 2/2] gnu: portaudio: Build with jack-1.
>
> * gnu/packages/audio.scm (portaudio)[inputs]: Replace "jack-2" with "jack-1".
LGTM. Perhaps a comment should be added next to this package or next to
‘jack-2’ to explain what you wrote above?
Thanks,
Ludo’.
prev parent reply other threads:[~2015-07-19 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 20:16 [PATCH] Propagate input for JACK; fix portaudio JACK-support Ricardo Wurmus
2015-07-19 21:05 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4ibkgdv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).