From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Propagate input for JACK; fix portaudio JACK-support
Date: Sun, 19 Jul 2015 23:05:16 +0200
Message-ID: <87y4ibkgdv.fsf@gnu.org>
References: <874ml1fch0.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvvb-0002o6-9O
	for guix-devel@gnu.org; Sun, 19 Jul 2015 17:15:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvvW-0002nl-W3
	for guix-devel@gnu.org; Sun, 19 Jul 2015 17:15:18 -0400
In-Reply-To: <874ml1fch0.fsf@elephly.net> (Ricardo Wurmus's message of "Sat,
	18 Jul 2015 22:16:27 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> while packaging Extempora I noticed that the portaudio does not seem to
> work with JACK.  Extempora uses portaudio and it would not create a JACK
> port.
>
> After I rebuilt portaudio with =E2=80=9Cjack-1=E2=80=9D rather than =E2=
=80=9Cjack-2=E2=80=9D Extempora
> would create a JACK port via portaudio successfully.  =E2=80=9Cjack-1=E2=
=80=9D had to be
> modified to propagate =E2=80=9Cbdb=E2=80=9D because the libjack headers i=
nclude it.
>
> Attached are these two patches.

Makes sense.

> In general I would suggest only to use =E2=80=9Cjack-1=E2=80=9D as an inp=
ut.  =E2=80=9Cjack-2=E2=80=9D
> is a different implementation, but it does not replace =E2=80=9Cjack-1=E2=
=80=9D.
> For a user it may make sense to install =E2=80=9Cjack-2=E2=80=9D because =
of DBus
> support, but for libraries it should not be needed.

OK.

> From 579dcf04e35a093ca6bb97efff5aaec19053c080 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:07:45 +0200
> Subject: [PATCH 1/2] gnu: jack-1: Propagate "bdb".
>
> * gnu/packages/audio.scm (jack-1)[inputs]: Move "bdb" from here...
>    [propagated-inputs]: ...to here.

LGTM.

> From 4238c7742fef8e7786569beefe79ca9188b50e8e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 18 Jul 2015 22:09:13 +0200
> Subject: [PATCH 2/2] gnu: portaudio: Build with jack-1.
>
> * gnu/packages/audio.scm (portaudio)[inputs]: Replace "jack-2" with "jack=
-1".

LGTM.  Perhaps a comment should be added next to this package or next to
=E2=80=98jack-2=E2=80=99 to explain what you wrote above?

Thanks,
Ludo=E2=80=99.