Re: [PATCH] gnu: Add denemo.

[Kei Kebreau <kei@openmailbox.org>]

[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>>
>>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>>
>>>>>> Hello all,
>>>>>>
>>>>>> I've completed a patch for GNU Denemo, though it has one minor issue. At
>>>>>> the end of the build it complains about a musical flat symbol in one of the
>>>>>> filenames. The other files like it use a "b" in place of the flat
>>>>>> symbol. Should I patch it just for Guix, or go upstream with my concerns
>>>>>> for consistency?
>>>>>
>>>>> What exactly complains about the character?  I think Guix should be able
>>>>> to handle this just fine.  Renaming the file because of what looks like
>>>>> a bug in Guix is not the right approach here.
>>>>>
>>>>> (Incidentally, I have a similar problem with “find-files”, which
>>>>> complains about files with non-ASCII characters in their name.)
>>>>>
>>>>> ~~ Ricardo
>>>>>
>>>>
>>>> I just checked. The issue is "find-files." Have you come up with a
>>>> solution to the issue, or is it just a bug in Guix that needs to be fixed?
>>>
>>> In my case it was because I used the “trivial-build-system”.  Unlike the
>>> “gnu-build-system” it does not have a build phase which installs a UTF-8
>>> locale.  The way around it was to reuse the locale setting code in the
>>> “install-locale” phase.
>>>
>>> This probably won’t help you as you are already using the
>>> “gnu-build-system” so the build phases should run in a UTF-8 locale.
>>> Could it be that the file is not UTF-8 encoded and you really need some
>>> other encoding?
>>>
>>> ~~ Ricardo
>>>
>>
>> If it helps, the issue with find-files only occurs during grafting. Do
>> you suppose this could be a bug in the Guix's grafting code?
>
> I don’t understand what this means.  Grafting happens *after* the build
> and is independent, no?  How can this have any effect on the behaviour
> of “find-files” then?
>
> Have you checked that there is no error when grafts are disabled?
>
> ~~ Ricardo
>

There isn't any error when grafts are disabled, and the formerly missing
file is present. All I can gather is that when grafting is enabled the
build occurs without a hitch, grafting denemo begins, and the following
error appears:

  grafting '/gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8' ->
  '/gnu/store/jc552i8jh5fpdhsfkxwlhmsx8vh5gw3n-denemo-2.0.8'...

  find-files:
  /gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8/share/denemo/templates/
  instruments/woodwind/Clarinet in B???.denemo: No such file or directory

Where the "???" represents a ♭ symbol.

-- 
Kei (GPG Key: 4096R/E6A5EE3C19467A0D)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]