unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add denemo.
Date: Fri, 09 Dec 2016 23:33:32 +0100	[thread overview]
Message-ID: <8760ms7mwz.fsf@gnu.org> (raw)
In-Reply-To: <87eg1g7p8n.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 09 Dec 2016 22:43:20 +0100")

ludo@gnu.org (Ludovic Courtès) skribis:

> Kei Kebreau <kei@openmailbox.org> skribis:

[...]

>> Everything seems fine except for grafting (i.e. disabling grafting
>> renders the issue invisible). For some reason, "find-files"
>> does not recognize a file with a Unicode-encoded filename when called
>> inside "rename-matching-files" from guix/build/graft.scm. When
>> "find-files" is used on its own, the file is recognized properly.
>> Is anyone familiar with the grafting code available to help figure out
>> what is happening to the file name?
>
> Problem is that the grafting code (‘graft-derivation/shallow’ in (guix
> grafts)) is running in the C locale, so it expects file names to be
> ASCII.  I’ll look into it.

Looking closer into it, may I suggest renaming the file in question?
:-)

The real fix would be for ‘graft-derivation/shallow’ to return a
dependency that depends on ‘glibc-utf8-locales’, but that can create
bootstrapping issues (also we don’t want unit tests to trigger a build
of ‘glibc-utf8-locales’ and everything before that).

Ludo’.

  reply	other threads:[~2016-12-09 22:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 19:09 [PATCH] gnu: Add denemo Kei Kebreau
2016-12-09 21:43 ` Ludovic Courtès
2016-12-09 22:33   ` Ludovic Courtès [this message]
2016-12-10  3:09   ` Kei Kebreau
2016-12-11  0:04     ` Ludovic Courtès
2016-12-11  9:07     ` Ricardo Wurmus
2016-12-11 22:49       ` Kei Kebreau
2016-12-12  6:32         ` Ricardo Wurmus
  -- strict thread matches above, loose matches on Subject: below --
2016-07-06 22:44 Kei Kebreau
2016-07-07  7:14 ` Ricardo Wurmus
2016-07-07 13:46   ` Kei Kebreau
2016-07-08  6:45     ` Ricardo Wurmus
2016-07-10 15:34       ` Kei Kebreau
2016-07-16 18:50       ` Kei Kebreau
2016-07-16 19:13         ` Ricardo Wurmus
2016-07-16 20:02           ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760ms7mwz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).