From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add denemo. Date: Sat, 16 Jul 2016 16:02:13 -0400 Message-ID: <87y4511hdm.fsf@openmailbox.org> References: <874m82crpp.fsf@openmailbox.org> <87h9c1zzr3.fsf@elephly.net> <87y45dblxj.fsf@openmailbox.org> <87wpkw39xt.fsf@elephly.net> <8760s52z8y.fsf@openmailbox.org> <8760s5iegt.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOVnO-0007rj-Nd for guix-devel@gnu.org; Sat, 16 Jul 2016 16:02:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOVnJ-0001uy-AC for guix-devel@gnu.org; Sat, 16 Jul 2016 16:02:41 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:50064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOVnI-0001uq-T6 for guix-devel@gnu.org; Sat, 16 Jul 2016 16:02:37 -0400 In-Reply-To: <8760s5iegt.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 16 Jul 2016 21:13:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Kei Kebreau writes: > >> Ricardo Wurmus writes: >> >>> Kei Kebreau writes: >>> >>>> Ricardo Wurmus writes: >>>> >>>>> Kei Kebreau writes: >>>>> >>>>>> Hello all, >>>>>> >>>>>> I've completed a patch for GNU Denemo, though it has one minor issue= . At >>>>>> the end of the build it complains about a musical flat symbol in one= of the >>>>>> filenames. The other files like it use a "b" in place of the flat >>>>>> symbol. Should I patch it just for Guix, or go upstream with my conc= erns >>>>>> for consistency? >>>>> >>>>> What exactly complains about the character? I think Guix should be a= ble >>>>> to handle this just fine. Renaming the file because of what looks li= ke >>>>> a bug in Guix is not the right approach here. >>>>> >>>>> (Incidentally, I have a similar problem with =E2=80=9Cfind-files=E2= =80=9D, which >>>>> complains about files with non-ASCII characters in their name.) >>>>> >>>>> ~~ Ricardo >>>>> >>>> >>>> I just checked. The issue is "find-files." Have you come up with a >>>> solution to the issue, or is it just a bug in Guix that needs to be fi= xed? >>> >>> In my case it was because I used the =E2=80=9Ctrivial-build-system=E2= =80=9D. Unlike the >>> =E2=80=9Cgnu-build-system=E2=80=9D it does not have a build phase which= installs a UTF-8 >>> locale. The way around it was to reuse the locale setting code in the >>> =E2=80=9Cinstall-locale=E2=80=9D phase. >>> >>> This probably won=E2=80=99t help you as you are already using the >>> =E2=80=9Cgnu-build-system=E2=80=9D so the build phases should run in a = UTF-8 locale. >>> Could it be that the file is not UTF-8 encoded and you really need some >>> other encoding? >>> >>> ~~ Ricardo >>> >> >> If it helps, the issue with find-files only occurs during grafting. Do >> you suppose this could be a bug in the Guix's grafting code? > > I don=E2=80=99t understand what this means. Grafting happens *after* the= build > and is independent, no? How can this have any effect on the behaviour > of =E2=80=9Cfind-files=E2=80=9D then? > > Have you checked that there is no error when grafts are disabled? > > ~~ Ricardo > There isn't any error when grafts are disabled, and the formerly missing file is present. All I can gather is that when grafting is enabled the build occurs without a hitch, grafting denemo begins, and the following error appears: grafting '/gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8' -> '/gnu/store/jc552i8jh5fpdhsfkxwlhmsx8vh5gw3n-denemo-2.0.8'... find-files: /gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8/share/denemo/tem= plates/ instruments/woodwind/Clarinet in B???.denemo: No such file or directory Where the "???" represents a =E2=99=AD symbol. =2D-=20 Kei (GPG Key: 4096R/E6A5EE3C19467A0D) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXipLFAAoJEOal7jwZRnoNtGkP/0DbIxsm41XmSMXcrwigDr0B p+e1l3HWEl2p7dR4H3M+k1vrv5li8BfHe4G3ysRacU9eBlxf5hcZ9wjB4zqHuez1 USaaw8665/c8VvZwlq90DN9q+Sd21NipI4zwgyUq11ANOjgYKVyT6xdnOae/KkLm eCBrqdp98DWby4YejvXe3SfD4WX9qbWUQG9MfASnL+W3/se7fwQVods5RarBzOmY MKoHpvwrcPngtoazzt1RUdxNUs9cyu64ZtnCp0u7FHXWhDeWcJjBKPcp2J47THMg /ngOiba+QmfOwuHI+llxA9lzBlEH8P5LMptXvmknLT+9UgMvx/Ce9+/oSNwZCXWv IU3Uh4ihNCp1i7qRd+ltd0tTy9dy7b89fyaY4UOW2oTEVUNmSY+/Z8wY8lomHo30 OJsX64NtelSWNsIDT02FJA30zZUD/F5PbAtLQUyQ8aLgC66YyVl41YoQuk3Av8tp 6aTRIkEdzy5QjDG3AFsMqL8l7x6z83Rx4q8CMazKCgEG4ke9r3u8MAj70tNABc+b u9HiPs+lbN12xVCSYbLW9UCcWHUvsXAA2ZRs9T4rBn1JksiEl8TE4K7XUIsE5Z+y 2VrgIVBtUobQt5UfTxd2sU4MAHq0P7B7lXHHe1OT4u2tEOI6jDoUXpglVNop6wrQ DNdysXYXIKK5c0tynLCn =bSKr -----END PGP SIGNATURE----- --=-=-=--