From: Ricardo Wurmus <rekado@elephly.net>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add denemo.
Date: Sat, 16 Jul 2016 21:13:06 +0200 [thread overview]
Message-ID: <8760s5iegt.fsf@elephly.net> (raw)
In-Reply-To: <8760s52z8y.fsf@openmailbox.org>
Kei Kebreau <kei@openmailbox.org> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>
>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>
>>>>> Hello all,
>>>>>
>>>>> I've completed a patch for GNU Denemo, though it has one minor issue. At
>>>>> the end of the build it complains about a musical flat symbol in one of the
>>>>> filenames. The other files like it use a "b" in place of the flat
>>>>> symbol. Should I patch it just for Guix, or go upstream with my concerns
>>>>> for consistency?
>>>>
>>>> What exactly complains about the character? I think Guix should be able
>>>> to handle this just fine. Renaming the file because of what looks like
>>>> a bug in Guix is not the right approach here.
>>>>
>>>> (Incidentally, I have a similar problem with “find-files”, which
>>>> complains about files with non-ASCII characters in their name.)
>>>>
>>>> ~~ Ricardo
>>>>
>>>
>>> I just checked. The issue is "find-files." Have you come up with a
>>> solution to the issue, or is it just a bug in Guix that needs to be fixed?
>>
>> In my case it was because I used the “trivial-build-system”. Unlike the
>> “gnu-build-system” it does not have a build phase which installs a UTF-8
>> locale. The way around it was to reuse the locale setting code in the
>> “install-locale” phase.
>>
>> This probably won’t help you as you are already using the
>> “gnu-build-system” so the build phases should run in a UTF-8 locale.
>> Could it be that the file is not UTF-8 encoded and you really need some
>> other encoding?
>>
>> ~~ Ricardo
>>
>
> If it helps, the issue with find-files only occurs during grafting. Do
> you suppose this could be a bug in the Guix's grafting code?
I don’t understand what this means. Grafting happens *after* the build
and is independent, no? How can this have any effect on the behaviour
of “find-files” then?
Have you checked that there is no error when grafts are disabled?
~~ Ricardo
next prev parent reply other threads:[~2016-07-16 19:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 22:44 [PATCH] gnu: Add denemo Kei Kebreau
2016-07-07 7:14 ` Ricardo Wurmus
2016-07-07 13:46 ` Kei Kebreau
2016-07-08 6:45 ` Ricardo Wurmus
2016-07-10 15:34 ` Kei Kebreau
2016-07-16 18:50 ` Kei Kebreau
2016-07-16 19:13 ` Ricardo Wurmus [this message]
2016-07-16 20:02 ` Kei Kebreau
-- strict thread matches above, loose matches on Subject: below --
2016-12-08 19:09 Kei Kebreau
2016-12-09 21:43 ` Ludovic Courtès
2016-12-09 22:33 ` Ludovic Courtès
2016-12-10 3:09 ` Kei Kebreau
2016-12-11 0:04 ` Ludovic Courtès
2016-12-11 9:07 ` Ricardo Wurmus
2016-12-11 22:49 ` Kei Kebreau
2016-12-12 6:32 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760s5iegt.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).