#f as a package description, gnu: Add rocminfo.

#f as a package description, gnu: Add rocminfo.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]


guix-commits@gnu.org writes:

> lbraun pushed a commit to branch master
> in repository guix.
>
> commit 91ce17a53236578f8055a2588460047741983925
> Author: Lars-Dominik Braun <lars@6xq.net>
> AuthorDate: Fri Aug 6 08:29:12 2021 +0200
>
>     gnu: Add rocminfo.
>
>     * gnu/packages/rocm.scm (rocminfo): New variable.
> ---
>  gnu/packages/rocm.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/rocm.scm b/gnu/packages/rocm.scm
> index 07e395c..0cf5a34 100644
> --- a/gnu/packages/rocm.scm
> +++ b/gnu/packages/rocm.scm
> @@ -304,3 +304,24 @@ allows runtimes to work on Windows as well as on Linux without much effort.")
>      (description "OpenCL 2.0 compatible language runtime, supporting offline
>  and in-process/in-memory compilation.")
>      (license license:ncsa)))
> +
> +(define-public rocminfo
> +  (package
> +    (name "rocminfo")
> +    (version %rocm-version)
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/RadeonOpenCompute/rocminfo.git")
> +                    (commit (string-append "rocm-" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0pcm308vwkjrwnrk507iya20mkil8j0vx699w9jk2gas4n4jvkcz"))))
> +    (build-system cmake-build-system)
> +    (arguments `(#:tests? #f)) ; No tests.
> +    (inputs `(("rocr-runtime" ,rocr-runtime)))
> +    (home-page "https://github.com/RadeonOpenCompute/rocminfo")
> +    (synopsis "ROCm Application for Reporting System Info")
> +    (description #f)
> +    (license license:ncsa)))

guix lint notes:
gnu/packages/rocm.scm:309:2: rocminfo@4.3.0: invalid description: #f

I noticed this because it broke an assumption about descriptions in the
Guix Data Service [1].

1: https://data.guix.gnu.org/revision/e81cf4e79a6e297db0ae2a9c39eab495e7e204f0

As this is now part of the history, I'll fix the Guix Data Service to be
able to cope when the description is #f.

Anyway, I wouldn't like for this change to lower the standard though,
it's currently the only package in Guix with an invalid description (as
far as I'm aware), is there some reason why it doesn't have one?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

Re: #f as a package description, gnu: Add rocminfo.

[Lars-Dominik Braun]

Hi Christopher,

> Anyway, I wouldn't like for this change to lower the standard though,
> it's currently the only package in Guix with an invalid description (as
> far as I'm aware), is there some reason why it doesn't have one?
it simply fell through the cracks[1]. Commit
0a379de3249d5e9ff66fb404f7e5aa8ce2cb3d24 adds a proper descripton.

Sorry for the trouble,
Lars

[1] Unfortunately I cannot run `guix lint` on an entire git changeset,
so instead I have to check each package by hand and I probably missed
rocminfo. I wish someday we can have a branch/pull-request-based
workflow with automated CI checks (linting, `guix pull`, signature
verification, …) *before* merging to master.

Re: #f as a package description, gnu: Add rocminfo.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]


Lars-Dominik Braun <lars@6xq.net> writes:

> Hi Christopher,
>
>> Anyway, I wouldn't like for this change to lower the standard though,
>> it's currently the only package in Guix with an invalid description (as
>> far as I'm aware), is there some reason why it doesn't have one?
> it simply fell through the cracks[1]. Commit
> 0a379de3249d5e9ff66fb404f7e5aa8ce2cb3d24 adds a proper descripton.
>
> Sorry for the trouble,

No problem, thanks for fixing it.

> [1] Unfortunately I cannot run `guix lint` on an entire git changeset,
> so instead I have to check each package by hand and I probably missed
> rocminfo. I wish someday we can have a branch/pull-request-based
> workflow with automated CI checks (linting, `guix pull`, signature
> verification, …) *before* merging to master.

This is something I've put some time in to, but it needs some general
support before I'm confident that the things I have in mind can become
reality. I recently started a thread on guix-devel [1] about what I have
in mind, so please comment if you're interested in this area.

1: https://lists.gnu.org/archive/html/guix-devel/2021-08/msg00001.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]