unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/16] gnu: Add hisat2.
Date: Tue, 17 Jan 2017 21:49:20 +0100	[thread overview]
Message-ID: <87tw8x76pb.fsf@elephly.net> (raw)
In-Reply-To: <20170117203639.GA17056@jasmine>


Leo Famulari <leo@famulari.name> writes:

> On Tue, Jan 17, 2017 at 03:11:27PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/bioinformatics.scm (hisat2): New variable.
>
>> +       #:make-flags (list "CC=gcc" "CXX=g++" "allall")
>
> "allall"... We can categorize this alongside -Weverything! ;)
>
>> +         (add-after 'unpack 'make-deterministic
>> +           (lambda _
>> +             (substitute* "Makefile"
>> +               (("`date`") "0"))
>
> I'd take the value of SOURCE_DATE_EPOCH from the environment, but it's
> not very important.

Oh, I’m sorry.  I have just pushed based on Marius’s review and didn’t
see your message in time.  I’ll keep SOURCE_DATE_EPOCH in mind for
future cases.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  reply	other threads:[~2017-01-17 20:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 14:11 [PATCH 00/16] Bioinfo stuff Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 01/16] gnu: Add python-argparse Ricardo Wurmus
2017-01-17 14:49   ` Hartmut Goebel
2017-01-17 15:26     ` Ricardo Wurmus
2017-01-17 18:48       ` Alex Kost
2017-01-17 18:47   ` Alex Kost
2017-01-17 14:11 ` [PATCH 02/16] gnu: Add hisat2 Ricardo Wurmus
2017-01-17 20:36   ` Leo Famulari
2017-01-17 20:49     ` Ricardo Wurmus [this message]
2017-01-17 14:11 ` [PATCH 03/16] gnu: Add ribodiff Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 04/16] gnu: Add r-compquadform Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 05/16] gnu: Add r-seqminer Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 06/16] gnu: Add r-raremetals2 Ricardo Wurmus
2017-01-20 13:16   ` Ludovic Courtès
2017-01-20 14:18     ` Ricardo Wurmus
2017-01-20 21:26       ` Ludovic Courtès
2017-01-17 14:11 ` [PATCH 07/16] gnu: Add r-maldiquant Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 08/16] gnu: Add r-protgenerics Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 09/16] gnu: Add r-mzr Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 10/16] gnu: Add r-affyio Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 11/16] gnu: Add r-affy Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 12/16] gnu: Add r-vsn Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 13/16] gnu: Add r-mzid Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 14/16] gnu: Add r-pcamethods Ricardo Wurmus
2017-01-17 14:11 ` [PATCH 15/16] gnu: Add r-msnbase Ricardo Wurmus
2017-01-20 13:17   ` Ludovic Courtès
2017-01-20 13:18   ` Ludovic Courtès
2017-01-17 14:11 ` [PATCH 16/16] gnu: Add r-msnid Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw8x76pb.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).