* Could guix lint check the copyright line? @ 2019-10-15 15:27 Pierre Neidhardt 2019-10-15 17:10 ` ng0 2019-10-19 20:21 ` Ludovic Courtès 0 siblings, 2 replies; 4+ messages in thread From: Pierre Neidhardt @ 2019-10-15 15:27 UTC (permalink / raw) To: guix-devel [-- Attachment #1: Type: text/plain, Size: 263 bytes --] Wouldn't it be neat if guix lint would automatically spot missing copyright lines in the file headers? It could rely on `git blame' to identify who wrote more than some 15 lines in a file. What do you think? -- Pierre Neidhardt https://ambrevar.xyz/ [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Could guix lint check the copyright line? 2019-10-15 15:27 Could guix lint check the copyright line? Pierre Neidhardt @ 2019-10-15 17:10 ` ng0 2019-10-15 17:17 ` Pierre Neidhardt 2019-10-19 20:21 ` Ludovic Courtès 1 sibling, 1 reply; 4+ messages in thread From: ng0 @ 2019-10-15 17:10 UTC (permalink / raw) To: guix-devel [-- Attachment #1: Type: text/plain, Size: 581 bytes --] Pierre Neidhardt transcribed 907 bytes: > Wouldn't it be neat if guix lint would automatically spot missing > copyright lines in the file headers? It could rely on `git blame' to > identify who wrote more than some 15 lines in a file. That's a really low threshold given that sometimes people changed 2 or 3 lines in a file or 1 and still get to add their copyright line. If we don't have it, no one will complain I guess. And then we have to distinguish author and commiter as well. > What do you think? > > -- > Pierre Neidhardt > https://ambrevar.xyz/ [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Could guix lint check the copyright line? 2019-10-15 17:10 ` ng0 @ 2019-10-15 17:17 ` Pierre Neidhardt 0 siblings, 0 replies; 4+ messages in thread From: Pierre Neidhardt @ 2019-10-15 17:17 UTC (permalink / raw) To: ng0, guix-devel [-- Attachment #1: Type: text/plain, Size: 444 bytes --] ng0 <ng0@n0.is> writes: > That's a really low threshold given that sometimes > people changed 2 or 3 lines in a file or 1 and still > get to add their copyright line. That's fine, we can also assign a copyright for 1 line. > If we don't have it, no one will complain I guess. And then we have to > distinguish author and commiter as well. Copyright goes to author, not committer. -- Pierre Neidhardt https://ambrevar.xyz/ [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Could guix lint check the copyright line? 2019-10-15 15:27 Could guix lint check the copyright line? Pierre Neidhardt 2019-10-15 17:10 ` ng0 @ 2019-10-19 20:21 ` Ludovic Courtès 1 sibling, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2019-10-19 20:21 UTC (permalink / raw) To: Pierre Neidhardt; +Cc: guix-devel Hi! Pierre Neidhardt <mail@ambrevar.xyz> skribis: > Wouldn't it be neat if guix lint would automatically spot missing > copyright lines in the file headers? It could rely on `git blame' to > identify who wrote more than some 15 lines in a file. > > What do you think? That check would have to be optional because ‘guix lint’ is not necessarily running from a Git checkout. Also, I wonder how frequent false-positives would be. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-19 20:21 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-15 15:27 Could guix lint check the copyright line? Pierre Neidhardt 2019-10-15 17:10 ` ng0 2019-10-15 17:17 ` Pierre Neidhardt 2019-10-19 20:21 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).