From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org
Subject: Re: How/where/when to ask for a patch review?
Date: Wed, 10 Jan 2024 00:33:11 +0100 [thread overview]
Message-ID: <87cyuaw094.fsf@gnu.org> (raw)
In-Reply-To: <ZZl2PvBe-fTnt_kj@ws> (Tomas Volf's message of "Sat, 6 Jan 2024 16:48:14 +0100")
Hi again Tomas,
Tomas Volf <~@wolfsden.cz> skribis:
> What I tried so far:
>
> 1) Asking on the IRC (2x). Once I even got a review, but from a non-committer.
> 2) Sending email directly to the main author of the edited source file. No
> response.
>
> Technically I even mentioned it to the main author directly in person, but it
> was at a conference, so I can hardly blame them for it just slipping by. :)
Uh, I think I’m the guilty party, my sincere apologies!
I have to admit I have a hard time keeping up. I review tons of
patches, but I also like to do stuff by myself, which means I tend to
select “easy” patches.
As a project, the ratio of available reviewer time to incoming patches
remains chronically small. I feel like there are more people reviewing
and pushing patches these days, but there’s also more patches coming
in—a good problem to have, but certainly also a source of frustration.
The good news is that I’ve now reviewed
<https://issues.guix.gnu.org/65002> and it looks almost ready to me. So
perhaps you’ll have to ping me or some other committer one last time,
but I encourage you to not give up, not so close to the finish line.
Cheers,
Ludo’.
next prev parent reply other threads:[~2024-01-09 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 15:48 How/where/when to ask for a patch review? Tomas Volf
2024-01-07 3:22 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-07 9:41 ` Nicolas Goaziou via Development of GNU Guix and the GNU System distribution.
2024-01-09 23:33 ` Ludovic Courtès [this message]
2024-01-10 14:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-10 16:59 ` Tomas Volf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyuaw094.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).