From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id DaNUIN3XnWUHqgAAkFu2QA (envelope-from ) for ; Wed, 10 Jan 2024 00:33:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id kNKuG93XnWVMEwAA62LTzQ (envelope-from ) for ; Wed, 10 Jan 2024 00:33:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=B0kDpWuw; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704843229; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=VlV0ptBBUA1lbnDfwXvjU1yKGNp8vEy7uaI2fzu1cdQ=; b=sNHlzq9Zi+0MylY4vBtUq9R4OLaPw5xNcPpNk9KTYR5b9in1dEGa/0tmt2o/HrFoDwjfMh tNob7eAYCJVKArYXn03Cx3lIl38Nif8E67lHFffO3MXSuLeq59Aln6ptd15BC5TbFM2AIV Ai4lXKhjYvSLT7lL8Lx9AwnplPoG3pqi0mVwvx4/bJ+sPnMMUL4JVo6luXOjd/b1KZXSZP RlEeAGdNvcGsRTa89K2bfNYkWGXm5vsHrAkDSXuOxIeaNWl4uIRaUXi0WltblgXKoNyLhL lP10RvqDLK9NfmVXbEyexbakPw8SgDL3X4PrXCLOpVz0weTB/5eZ3fBHEIhVPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704843229; a=rsa-sha256; cv=none; b=LkQxBGrHuVN1r2CRjPDSFZlekFUYHZKlgdVKCJL3MoHGCbkXeTJnAomIGtqOUleANKuz+k q3IATTI21YtdgfGK+gwrrwAdiw/rV/1mazDNDIQftLdkQ0mw7x2rplicognsTA66zZ6d0C M1bWdgGbmWBhfCGba++kk+jnQu6Dqfn9pJC0H8fQFzhSGAS8/KkuMLhUKA2H+hV5oJHz3u HUCrtHGL0HtffP/Xel4yf66K3eYK5KW+aDYrn8O7g5BCSmK27Kw04IC9ZXnbaiCGqYrLb6 LRcsLxBp4RpHhDAyqgzboGs9r8aBffPBbnLT5JOK9dxQ0OvmuTXvrk9e3F6bow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=B0kDpWuw; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54E7133EFE for ; Wed, 10 Jan 2024 00:33:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNLb0-0006kA-Hl; Tue, 09 Jan 2024 18:33:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNLaz-0006jz-JV for guix-devel@gnu.org; Tue, 09 Jan 2024 18:33:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNLaz-0001ZW-AU for guix-devel@gnu.org; Tue, 09 Jan 2024 18:33:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=VlV0ptBBUA1lbnDfwXvjU1yKGNp8vEy7uaI2fzu1cdQ=; b=B0kDpWuwQ3sENEUE7+6R RnyIUSTnApvKnXUlT1qx0YFOyz4q467+hCCXKhmr+gH61wxB7c+1iR92ByPYuPXkzVcITyaX6dVcp Tfrj5+1BcvmD6cs7MNiEWFNOc9mBWmr/szl+VNar5HgVqdjNomx9RMwfgBYzOzUoulwUZpVr+LATi dNwrDtqZETfXf6NSSmRd5KbP8J4zMdjCV8AZbKIxyCWhds9JQmdcuXc+a7Kw+K9dy7yQOk5z9+6d8 AbrXlwTlHDeuM4rdsYh0WBOeIx20CzMr1vZ5Oh2EsZ8xQx/SvFyyT3aaAyLaCrLikLF+ueXigjhi2 8sio2wA1XQ8YlQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: How/where/when to ask for a patch review? In-Reply-To: (Tomas Volf's message of "Sat, 6 Jan 2024 16:48:14 +0100") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 21 =?utf-8?Q?Niv=C3=B4se?= an 232 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Pierre =?utf-8?B?w6AgcGzDonRyZQ==?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 10 Jan 2024 00:33:11 +0100 Message-ID: <87cyuaw094.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.53 X-Spam-Score: -5.53 X-Migadu-Queue-Id: 54E7133EFE X-Migadu-Scanner: mx12.migadu.com X-TUID: K1Vn57+3cm8l Hi again Tomas, Tomas Volf <~@wolfsden.cz> skribis: > What I tried so far: > > 1) Asking on the IRC (2x). Once I even got a review, but from a non-comm= itter. > 2) Sending email directly to the main author of the edited source file. = No > response. > > Technically I even mentioned it to the main author directly in person, bu= t it > was at a conference, so I can hardly blame them for it just slipping by. = :) Uh, I think I=E2=80=99m the guilty party, my sincere apologies! I have to admit I have a hard time keeping up. I review tons of patches, but I also like to do stuff by myself, which means I tend to select =E2=80=9Ceasy=E2=80=9D patches. As a project, the ratio of available reviewer time to incoming patches remains chronically small. I feel like there are more people reviewing and pushing patches these days, but there=E2=80=99s also more patches coming in=E2=80=94a good problem to have, but certainly also a source of frustrati= on. The good news is that I=E2=80=99ve now reviewed and it looks almost ready to me. So perhaps you=E2=80=99ll have to ping me or some other committer one last tim= e, but I encourage you to not give up, not so close to the finish line. Cheers, Ludo=E2=80=99.