From: Nicolas Goaziou via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: Felix Lechner via "Development of GNU Guix and the GNU System
distribution." <guix-devel@gnu.org>
Cc: Tomas Volf <~@wolfsden.cz>, Felix Lechner <felix.lechner@lease-up.com>
Subject: Re: How/where/when to ask for a patch review?
Date: Sun, 07 Jan 2024 10:41:00 +0100 [thread overview]
Message-ID: <871qatjxar.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87msth6d4m.fsf@lease-up.com> (Felix Lechner via's message of "Sat, 06 Jan 2024 19:22:49 -0800")
Hello,
Felix Lechner via "Development of GNU Guix and the GNU System
distribution." <guix-devel@gnu.org> writes:
> On Sat, Jan 06 2024, Tomas Volf wrote:
>
>> what is the proper channel to ask for a patch review and how long
>> should one wait before doing so.
I think it is reasonable to bump the bug report associated to your patch
after a week, or possibly two during a winter break.
Note that committers generally wait for a green flag in the QA page
<https://qa.guix.gnu.org/patches>. Unfortunately, I noticed it had some
hiccups recently.
> Please don't waste your time waiting. The process of patch review and
> acceptance here is erratic. I won't go into reasons; the project
> understands the problem and is trying several solutions but I'm not sure
> they are working. Please go ahead and maintain your own fork of Guix.
It is certainly a pragmatic answer, but hopefully, we can do better.
> No chance. I run about a hundred patches on top of stock and build half
> of all packages myself (mainly due to a defective eudev in Guix). In
> another month, I'll be at two hundred.
IMHO, at this point, you should ask for write access to the project,
This would certainly help everyone involved.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2024-01-07 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 15:48 How/where/when to ask for a patch review? Tomas Volf
2024-01-07 3:22 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-07 9:41 ` Nicolas Goaziou via Development of GNU Guix and the GNU System distribution. [this message]
2024-01-09 23:33 ` Ludovic Courtès
2024-01-10 14:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-10 16:59 ` Tomas Volf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qatjxar.fsf@nicolasgoaziou.fr \
--to=guix-devel@gnu.org \
--cc=felix.lechner@lease-up.com \
--cc=mail@nicolasgoaziou.fr \
--cc=~@wolfsden.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).