* [Patch] Provide single-precision fftw library for pulseaudio
@ 2014-03-21 19:21 Eric Bavier
2014-03-22 14:25 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Eric Bavier @ 2014-03-21 19:21 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
Here's a patch to let pulseaudio use fftw for its equalizer. It needs
an fftw that was configured using "--with-float", otherwise its
configure just prints "Package fftw3f was not found in the pkg-config
search path".
If the syntax could be improved, I'd like to hear about that.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Provide-single-precision-fftw-library-for-pulsea.patch --]
[-- Type: text/x-diff, Size: 1916 bytes --]
From 3bd90c044c687cdd93cca63e68664874f76b5edb Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@member.fsf.org>
Date: Fri, 21 Mar 2014 14:06:40 -0500
Subject: [PATCH] gnu: Provide single-precision fftw library for pulseaudio
* gnu/packages/algebra.scm (fftwf): New variable
* gnu/packages/pulseaudio.scm (pulseaudio): Use it
* gnu/packages/algebra.scm
---
gnu/packages/algebra.scm | 12 +++++++++++-
gnu/packages/pulseaudio.scm | 2 +-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index a1564e0..1c53f55 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -27,7 +27,8 @@
#:use-module (guix licenses)
#:use-module (guix packages)
#:use-module (guix download)
- #:use-module (guix build-system gnu))
+ #:use-module (guix build-system gnu)
+ #:use-module (guix utils))
(define-public mpfrcx
@@ -231,3 +232,12 @@ transform (DFT) in one or more dimensions, of arbitrary input size, and of
both real and complex data (as well as of even/odd data---i.e. the discrete
cosine/ sine transforms or DCT/DST).")
(license gpl2+)))
+
+(define-public fftwf
+ (package (inherit fftw)
+ (name "fftwf")
+ (arguments
+ `(,@(substitute-keyword-arguments (package-arguments fftw)
+ ((#:configure-flags cf)
+ `(cons "--enable-float"
+ ,cf)))))))
\ No newline at end of file
diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index db7e752..d82f4be 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -168,7 +168,7 @@ parse JSON formatted strings back into the C representation of JSON objects.")
("pkg-config" ,pkg-config)
("m4" ,m4)
("libtool" ,libtool)
- ("fftw" ,fftw)
+ ("fftwf" ,fftwf)
("avahi" ,avahi)
("check" ,check)))
(propagated-inputs
--
1.7.9.5
[-- Attachment #3: Type: text/plain, Size: 12 bytes --]
--
`~Eric
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] Provide single-precision fftw library for pulseaudio
2014-03-21 19:21 [Patch] Provide single-precision fftw library for pulseaudio Eric Bavier
@ 2014-03-22 14:25 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2014-03-22 14:25 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
Eric Bavier <ericbavier@gmail.com> skribis:
> Here's a patch to let pulseaudio use fftw for its equalizer. It needs
> an fftw that was configured using "--with-float", otherwise its
> configure just prints "Package fftw3f was not found in the pkg-config
> search path".
OK.
> From 3bd90c044c687cdd93cca63e68664874f76b5edb Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Fri, 21 Mar 2014 14:06:40 -0500
> Subject: [PATCH] gnu: Provide single-precision fftw library for pulseaudio
>
> * gnu/packages/algebra.scm (fftwf): New variable
> * gnu/packages/pulseaudio.scm (pulseaudio): Use it
>
> * gnu/packages/algebra.scm
Typo here.
> +(define-public fftwf
> + (package (inherit fftw)
> + (name "fftwf")
> + (arguments
> + `(,@(substitute-keyword-arguments (package-arguments fftw)
> + ((#:configure-flags cf)
> + `(cons "--enable-float"
> + ,cf)))))))
`(,@lst) is equivalent to lst (info "(guile) Expression Syntax"). So
you simplify this accordingly.
Also, could you add a ‘description’ field that mentioned “(single
precision)”?
OK to commit with these changes.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-22 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-21 19:21 [Patch] Provide single-precision fftw library for pulseaudio Eric Bavier
2014-03-22 14:25 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).