From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [Patch] Provide single-precision fftw library for pulseaudio
Date: Sat, 22 Mar 2014 15:25:32 +0100 [thread overview]
Message-ID: <87bnwyxqcj.fsf@gnu.org> (raw)
In-Reply-To: <87pplf5pdz.fsf@gmail.com> (Eric Bavier's message of "Fri, 21 Mar 2014 14:21:28 -0500")
Eric Bavier <ericbavier@gmail.com> skribis:
> Here's a patch to let pulseaudio use fftw for its equalizer. It needs
> an fftw that was configured using "--with-float", otherwise its
> configure just prints "Package fftw3f was not found in the pkg-config
> search path".
OK.
> From 3bd90c044c687cdd93cca63e68664874f76b5edb Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Fri, 21 Mar 2014 14:06:40 -0500
> Subject: [PATCH] gnu: Provide single-precision fftw library for pulseaudio
>
> * gnu/packages/algebra.scm (fftwf): New variable
> * gnu/packages/pulseaudio.scm (pulseaudio): Use it
>
> * gnu/packages/algebra.scm
Typo here.
> +(define-public fftwf
> + (package (inherit fftw)
> + (name "fftwf")
> + (arguments
> + `(,@(substitute-keyword-arguments (package-arguments fftw)
> + ((#:configure-flags cf)
> + `(cons "--enable-float"
> + ,cf)))))))
`(,@lst) is equivalent to lst (info "(guile) Expression Syntax"). So
you simplify this accordingly.
Also, could you add a ‘description’ field that mentioned “(single
precision)”?
OK to commit with these changes.
Thanks!
Ludo’.
prev parent reply other threads:[~2014-03-22 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 19:21 [Patch] Provide single-precision fftw library for pulseaudio Eric Bavier
2014-03-22 14:25 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnwyxqcj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).