From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch] Provide single-precision fftw library for pulseaudio
Date: Sat, 22 Mar 2014 15:25:32 +0100
Message-ID: <87bnwyxqcj.fsf@gnu.org>
References: <87pplf5pdz.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WRMrj-0004xz-Pd
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:25:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WRMrd-0005K5-UK
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:25:39 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:44508)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WRMrd-0005Ja-Ld
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:25:33 -0400
In-Reply-To: <87pplf5pdz.fsf@gmail.com> (Eric Bavier's message of "Fri, 21 Mar
	2014 14:21:28 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> Here's a patch to let pulseaudio use fftw for its equalizer.  It needs
> an fftw that was configured using "--with-float", otherwise its
> configure just prints "Package fftw3f was not found in the pkg-config
> search path".

OK.

> From 3bd90c044c687cdd93cca63e68664874f76b5edb Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Fri, 21 Mar 2014 14:06:40 -0500
> Subject: [PATCH] gnu: Provide single-precision fftw library for pulseaudio
>
> * gnu/packages/algebra.scm (fftwf): New variable
> * gnu/packages/pulseaudio.scm (pulseaudio): Use it
>
> * gnu/packages/algebra.scm

Typo here.

> +(define-public fftwf
> +  (package (inherit fftw)
> +    (name "fftwf")
> +    (arguments
> +     `(,@(substitute-keyword-arguments (package-arguments fftw)
> +           ((#:configure-flags cf)
> +            `(cons "--enable-float"
> +                   ,cf)))))))

`(,@lst) is equivalent to lst (info "(guile) Expression Syntax").  So
you simplify this accordingly.

Also, could you add a =E2=80=98description=E2=80=99 field that mentioned =
=E2=80=9C(single
precision)=E2=80=9D?

OK to commit with these changes.

Thanks!

Ludo=E2=80=99.