* Re: 01/05: build-self: Avoid deprecated bindings.
[not found] ` <20190422190549.188DA20C04@vcs0.savannah.gnu.org>
@ 2019-04-22 22:53 ` Ludovic Courtès
2019-04-23 1:01 ` Mark H Weaver
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2019-04-22 22:53 UTC (permalink / raw)
To: guix-devel, Mark H Weaver
Hi Mark,
guix-commits@gnu.org skribis:
> commit fa9e6e8b676ca920a894cf3b48bfcb670077144f
> Author: Mark H Weaver <mhw@netris.org>
> Date: Sun Apr 21 13:58:08 2019 -0400
>
> build-self: Avoid deprecated bindings.
>
> * build-aux/build-self.scm (build): Replace references to nix-server-*
> with store-connection-*.
I reverted this commit because by using the new bindings, we would
prevent users of Guix prior to de9fbe9cdcf5f8deb08becfc54b523084fd67bda,
such as version 0.16.0, to upgrade to current master.
We will have to keep using the old names in this file for a while.
This file is a bit special in that we have to assume that it can be
evaluated by an old Guix.
Note that commit 3a8c4860fbccc840b28227dbe44cfffb128a91e0 took care of
silencing deprecation warnings coming from build-self.scm for this
reason.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 01/05: build-self: Avoid deprecated bindings.
2019-04-22 22:53 ` 01/05: build-self: Avoid deprecated bindings Ludovic Courtès
@ 2019-04-23 1:01 ` Mark H Weaver
0 siblings, 0 replies; 2+ messages in thread
From: Mark H Weaver @ 2019-04-23 1:01 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Ludovic Courtès <ludo@gnu.org> writes:
> guix-commits@gnu.org skribis:
>
>> commit fa9e6e8b676ca920a894cf3b48bfcb670077144f
>> Author: Mark H Weaver <mhw@netris.org>
>> Date: Sun Apr 21 13:58:08 2019 -0400
>>
>> build-self: Avoid deprecated bindings.
>>
>> * build-aux/build-self.scm (build): Replace references to nix-server-*
>> with store-connection-*.
>
> I reverted this commit because by using the new bindings, we would
> prevent users of Guix prior to de9fbe9cdcf5f8deb08becfc54b523084fd67bda,
> such as version 0.16.0, to upgrade to current master.
Ah, okay, sorry for the mistake. It might be worth adding a comment to
the code, explaining why the deprecated names must be used.
> Note that commit 3a8c4860fbccc840b28227dbe44cfffb128a91e0 took care of
> silencing deprecation warnings coming from build-self.scm for this
> reason.
Sounds good. Thanks!
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-23 1:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190422190547.15038.16393@vcs0.savannah.gnu.org>
[not found] ` <20190422190549.188DA20C04@vcs0.savannah.gnu.org>
2019-04-22 22:53 ` 01/05: build-self: Avoid deprecated bindings Ludovic Courtès
2019-04-23 1:01 ` Mark H Weaver
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).