From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/05: build-self: Avoid deprecated bindings. Date: Mon, 22 Apr 2019 21:01:30 -0400 Message-ID: <877eblsfei.fsf@netris.org> References: <20190422190547.15038.16393@vcs0.savannah.gnu.org> <20190422190549.188DA20C04@vcs0.savannah.gnu.org> <87wojly7mb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:56671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIjwW-00022W-D4 for guix-devel@gnu.org; Mon, 22 Apr 2019 21:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIjq2-0004Mc-Aw for guix-devel@gnu.org; Mon, 22 Apr 2019 21:03:12 -0400 In-Reply-To: <87wojly7mb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 23 Apr 2019 00:53:32 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > guix-commits@gnu.org skribis: > >> commit fa9e6e8b676ca920a894cf3b48bfcb670077144f >> Author: Mark H Weaver >> Date: Sun Apr 21 13:58:08 2019 -0400 >> >> build-self: Avoid deprecated bindings. >>=20=20=20=20=20 >> * build-aux/build-self.scm (build): Replace references to nix-server= -* >> with store-connection-*. > > I reverted this commit because by using the new bindings, we would > prevent users of Guix prior to de9fbe9cdcf5f8deb08becfc54b523084fd67bda, > such as version 0.16.0, to upgrade to current master. Ah, okay, sorry for the mistake. It might be worth adding a comment to the code, explaining why the deprecated names must be used. > Note that commit 3a8c4860fbccc840b28227dbe44cfffb128a91e0 took care of > silencing deprecation warnings coming from build-self.scm for this > reason. Sounds good. Thanks! Mark