From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/05: build-self: Avoid deprecated bindings.
Date: Mon, 22 Apr 2019 21:01:30 -0400 [thread overview]
Message-ID: <877eblsfei.fsf@netris.org> (raw)
In-Reply-To: <87wojly7mb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 23 Apr 2019 00:53:32 +0200")
Ludovic Courtès <ludo@gnu.org> writes:
> guix-commits@gnu.org skribis:
>
>> commit fa9e6e8b676ca920a894cf3b48bfcb670077144f
>> Author: Mark H Weaver <mhw@netris.org>
>> Date: Sun Apr 21 13:58:08 2019 -0400
>>
>> build-self: Avoid deprecated bindings.
>>
>> * build-aux/build-self.scm (build): Replace references to nix-server-*
>> with store-connection-*.
>
> I reverted this commit because by using the new bindings, we would
> prevent users of Guix prior to de9fbe9cdcf5f8deb08becfc54b523084fd67bda,
> such as version 0.16.0, to upgrade to current master.
Ah, okay, sorry for the mistake. It might be worth adding a comment to
the code, explaining why the deprecated names must be used.
> Note that commit 3a8c4860fbccc840b28227dbe44cfffb128a91e0 took care of
> silencing deprecation warnings coming from build-self.scm for this
> reason.
Sounds good. Thanks!
Mark
prev parent reply other threads:[~2019-04-23 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190422190547.15038.16393@vcs0.savannah.gnu.org>
[not found] ` <20190422190549.188DA20C04@vcs0.savannah.gnu.org>
2019-04-22 22:53 ` 01/05: build-self: Avoid deprecated bindings Ludovic Courtès
2019-04-23 1:01 ` Mark H Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eblsfei.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).