From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add denemo. Date: Sat, 16 Jul 2016 21:13:06 +0200 Message-ID: <8760s5iegt.fsf@elephly.net> References: <874m82crpp.fsf@openmailbox.org> <87h9c1zzr3.fsf@elephly.net> <87y45dblxj.fsf@openmailbox.org> <87wpkw39xt.fsf@elephly.net> <8760s52z8y.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOV1Y-0002Fh-9g for guix-devel@gnu.org; Sat, 16 Jul 2016 15:13:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOV1V-0001nY-1z for guix-devel@gnu.org; Sat, 16 Jul 2016 15:13:16 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOV1U-0001nR-Oe for guix-devel@gnu.org; Sat, 16 Jul 2016 15:13:12 -0400 In-reply-to: <8760s52z8y.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org Kei Kebreau writes: > Ricardo Wurmus writes: > >> Kei Kebreau writes: >> >>> Ricardo Wurmus writes: >>> >>>> Kei Kebreau writes: >>>> >>>>> Hello all, >>>>> >>>>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>>>> the end of the build it complains about a musical flat symbol in one of the >>>>> filenames. The other files like it use a "b" in place of the flat >>>>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>>>> for consistency? >>>> >>>> What exactly complains about the character? I think Guix should be able >>>> to handle this just fine. Renaming the file because of what looks like >>>> a bug in Guix is not the right approach here. >>>> >>>> (Incidentally, I have a similar problem with “find-files”, which >>>> complains about files with non-ASCII characters in their name.) >>>> >>>> ~~ Ricardo >>>> >>> >>> I just checked. The issue is "find-files." Have you come up with a >>> solution to the issue, or is it just a bug in Guix that needs to be fixed? >> >> In my case it was because I used the “trivial-build-system”. Unlike the >> “gnu-build-system” it does not have a build phase which installs a UTF-8 >> locale. The way around it was to reuse the locale setting code in the >> “install-locale” phase. >> >> This probably won’t help you as you are already using the >> “gnu-build-system” so the build phases should run in a UTF-8 locale. >> Could it be that the file is not UTF-8 encoded and you really need some >> other encoding? >> >> ~~ Ricardo >> > > If it helps, the issue with find-files only occurs during grafting. Do > you suppose this could be a bug in the Guix's grafting code? I don’t understand what this means. Grafting happens *after* the build and is independent, no? How can this have any effect on the behaviour of “find-files” then? Have you checked that there is no error when grafts are disabled? ~~ Ricardo