unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 0/3] Add perl-log modules
@ 2016-07-16 18:20 Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-16 18:20 UTC (permalink / raw)
  To: guix-devel

Hello,

The following 3 patches add perl-log modules.  As per usual they pass lint and
a pure environment build.

I now have commit access, but just to be sure I will continue to wait for
review for the next few submissions of even simple packages before committing
them myself.

Apologies for the confused email configuration — my actual smtp server is
currently having problems :-(

Best wishes

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

-- 
2.8.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/3] gnu: Add perl-log-any.
  2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
@ 2016-07-16 18:20 ` Alex Sassmannshausen
  2016-07-17  3:04   ` Ben Woodcroft
  2016-07-16 18:20 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
  2 siblings, 1 reply; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-16 18:20 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/perl.scm (perl-log-any): New variable.
---
 gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index aed2a61..486dbc2 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2939,6 +2939,37 @@ either uses the first module it finds or throws an error.")
 versa.")
     (license (package-license perl))))
 
+(define-public perl-log-any
+  (package
+    (name "perl-log-any")
+    (version "1.040")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0r1q7cclgwl24gzdnjzvd8y0r7j17dngjk492x35w198zhdj2ncp"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Log-Any")
+    (synopsis "Bringing loggers and listeners together")
+    (description "Log::Any provides a standard log production API for
+modules.  Log::Any::Adapter allows applications to choose the mechanism for log
+consumption, whether screen, file or another logging mechanism like
+Log::Dispatch or Log::Log4perl.
+
+A CPAN module uses Log::Any to get a log producer object.  An application, in
+turn, may choose one or more logging mechanisms via Log::Any::Adapter, or none
+at all.
+
+Log::Any has a very tiny footprint and no dependencies beyond Perl 5.8.1,
+which makes it appropriate for even small CPAN modules to use.  It defaults to
+'null' logging activity, so a module can safely log without worrying about
+whether the application has chosen (or will ever choose) a logging
+mechanism.")
+    (license (package-license perl))))
+
 (define-public perl-log-report-optional
   (package
     (name "perl-log-report-optional")
-- 
2.8.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/3] gnu: Add perl-log-log4perl.
  2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
@ 2016-07-16 18:20 ` Alex Sassmannshausen
  2016-07-17  3:06   ` Ben Woodcroft
  2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
  2 siblings, 1 reply; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-16 18:20 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/perl.scm (perl-log-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 486dbc2..fc63df3 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-log4perl
+  (package
+    (name "perl-log-log4perl")
+    (version "1.47")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
+    (build-system perl-build-system)
+    (home-page
+     "http://search.cpan.org/dist/Log-Log4perl")
+    (synopsis "Log4j implementation for Perl")
+    (description "Log::Log4perl lets you remote-control and fine-tune the
+logging behaviour of your system from the outside.  It implements the widely
+popular (Java-based) Log4j logging package in pure Perl.
+
+For a detailed tutorial on Log::Log4perl usage, please read
+
+http://www.perl.com/pub/a/2002/09/11/log4perl.html")
+    (license (package-license perl))))
+
 (define-public perl-log-report-optional
   (package
     (name "perl-log-report-optional")
-- 
2.8.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
@ 2016-07-16 18:20 ` Alex Sassmannshausen
  2016-07-17  3:10   ` Ben Woodcroft
  2016-07-17  8:44   ` Ricardo Wurmus
  2 siblings, 2 replies; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-16 18:20 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fc63df3..1f18214 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (native-inputs `(("perl-log-any" ,perl-log-any)))
+    (inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
+using Log::Log4perl for logging.  log4perl must be initialized before calling
+set.  There are no parameters.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")
-- 
2.8.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/3] gnu: Add perl-log-any.
  2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
@ 2016-07-17  3:04   ` Ben Woodcroft
  0 siblings, 0 replies; 14+ messages in thread
From: Ben Woodcroft @ 2016-07-17  3:04 UTC (permalink / raw)
  To: Alex Sassmannshausen, guix-devel

Thanks. I was in the process of packaging log4perl also, you beat me to it.

On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any): New variable.
> ---
>   gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index aed2a61..486dbc2 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2939,6 +2939,37 @@ either uses the first module it finds or throws an error.")
>   versa.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any
> +  (package
> +    (name "perl-log-any")
> +    (version "1.040")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0r1q7cclgwl24gzdnjzvd8y0r7j17dngjk492x35w198zhdj2ncp"))))
> +    (build-system perl-build-system)
> +    (home-page "http://search.cpan.org/dist/Log-Any")
> +    (synopsis "Bringing loggers and listeners together")
> +    (description "Log::Any provides a standard log production API for
> +modules.  Log::Any::Adapter allows applications to choose the mechanism for log
> +consumption, whether screen, file or another logging mechanism like
> +Log::Dispatch or Log::Log4perl.
> +
> +A CPAN module uses Log::Any to get a log producer object.  An application, in
> +turn, may choose one or more logging mechanisms via Log::Any::Adapter, or none
> +at all.
> +
> +Log::Any has a very tiny footprint and no dependencies beyond Perl 5.8.1,

A reference to the specific Perl version is a bit out of place, no? 
Maybe 'no dependencies beyond Perl itself'. Otherwise LGTM.

> +which makes it appropriate for even small CPAN modules to use.  It defaults to
> +'null' logging activity, so a module can safely log without worrying about
> +whether the application has chosen (or will ever choose) a logging
> +mechanism.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-report-optional
>     (package
>       (name "perl-log-report-optional")

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/3] gnu: Add perl-log-log4perl.
  2016-07-16 18:20 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
@ 2016-07-17  3:06   ` Ben Woodcroft
  2016-07-17 13:27     ` Ludovic Courtès
  0 siblings, 1 reply; 14+ messages in thread
From: Ben Woodcroft @ 2016-07-17  3:06 UTC (permalink / raw)
  To: Alex Sassmannshausen, guix-devel



On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 486dbc2..fc63df3 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-log4perl
> +  (package
> +    (name "perl-log-log4perl")
> +    (version "1.47")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
> +    (build-system perl-build-system)
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Log4perl")
> +    (synopsis "Log4j implementation for Perl")
> +    (description "Log::Log4perl lets you remote-control and fine-tune the
> +logging behaviour of your system from the outside.  It implements the widely
> +popular (Java-based) Log4j logging package in pure Perl.
> +
> +For a detailed tutorial on Log::Log4perl usage, please read
> +
> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")

Is it appropriate to wrap this URL in some tex? I'm not sure what would 
be appropriate in this case. Otherwise LGTM.

> +    (license (package-license perl))))
> +
>   (define-public perl-log-report-optional
>     (package
>       (name "perl-log-report-optional")

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
@ 2016-07-17  3:10   ` Ben Woodcroft
  2016-07-17  8:44   ` Ricardo Wurmus
  1 sibling, 0 replies; 14+ messages in thread
From: Ben Woodcroft @ 2016-07-17  3:10 UTC (permalink / raw)
  To: Alex Sassmannshausen, guix-devel



On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)

This is both an input and a native-input - I imagine the former is best.

> +       ("perl-log-log4perl" ,perl-log-log4perl)))
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
> +    (synopsis "Log::Any adapter for Log::Log4perl")
> +    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
> +using Log::Log4perl for logging.  log4perl must be initialized before calling
> +set.  There are no parameters.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-log4perl
>     (package
>       (name "perl-log-log4perl")

OK.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
  2016-07-17  3:10   ` Ben Woodcroft
@ 2016-07-17  8:44   ` Ricardo Wurmus
  1 sibling, 0 replies; 14+ messages in thread
From: Ricardo Wurmus @ 2016-07-17  8:44 UTC (permalink / raw)
  To: Alex Sassmannshausen; +Cc: guix-devel


Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>  mechanism.")
>      (license (package-license perl))))
>  
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)
> +       ("perl-log-log4perl" ,perl-log-log4perl)))

Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have
anything comparable to the RUNPATH feature, so inputs must be
propagated.

Have you tested using this module, e.g. in a container?

~~ Ricardo

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
@ 2016-07-17 10:17 Alex Sassmannshausen
  0 siblings, 0 replies; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-17 10:17 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

Hi Ricardo,

On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
>
>
> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
>
> > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > --- 
> >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> >  1 file changed, 27 insertions(+) 
> > 
> > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > index fc63df3..1f18214 100644 
> > --- a/gnu/packages/perl.scm 
> > +++ b/gnu/packages/perl.scm 
> > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> >  mechanism.") 
> >      (license (package-license perl)))) 
> >  
> > +(define-public perl-log-any-adapter-log4perl 
> > +  (package 
> > +    (name "perl-log-any-adapter-log4perl") 
> > +    (version "0.08") 
> > +    (source 
> > +     (origin 
> > +       (method url-fetch) 
> > +       (uri (string-append 
> > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > +             version 
> > +             ".tar.gz")) 
> > +       (sha256 
> > +        (base32 
> > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > +    (build-system perl-build-system) 
> > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > +    (inputs 
> > +     `(("perl-log-any" ,perl-log-any) 
> > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
>
> Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> anything comparable to the RUNPATH feature, so inputs must be 
> propagated. 
>
> Have you tested using this module, e.g. in a container?

You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.

I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.

Thanks for your review!

Alex

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
@ 2016-07-17 10:46 Alex Sassmannshausen
  2016-07-18  8:29 ` Ricardo Wurmus
  0 siblings, 1 reply; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-17 10:46 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel


On 17 Jul 2016 12:17, Alex Sassmannshausen <alex@pompo.co> wrote:
>
> Hi Ricardo,
>
> On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
> >
> >
> > Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
> >
> > > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > > --- 
> > >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> > >  1 file changed, 27 insertions(+) 
> > > 
> > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > > index fc63df3..1f18214 100644 
> > > --- a/gnu/packages/perl.scm 
> > > +++ b/gnu/packages/perl.scm 
> > > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> > >  mechanism.") 
> > >      (license (package-license perl)))) 
> > >  
> > > +(define-public perl-log-any-adapter-log4perl 
> > > +  (package 
> > > +    (name "perl-log-any-adapter-log4perl") 
> > > +    (version "0.08") 
> > > +    (source 
> > > +     (origin 
> > > +       (method url-fetch) 
> > > +       (uri (string-append 
> > > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > > +             version 
> > > +             ".tar.gz")) 
> > > +       (sha256 
> > > +        (base32 
> > > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > > +    (build-system perl-build-system) 
> > > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > > +    (inputs 
> > > +     `(("perl-log-any" ,perl-log-any) 
> > > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
> >
> > Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> > anything comparable to the RUNPATH feature, so inputs must be 
> > propagated. 
> >
> > Have you tested using this module, e.g. in a container?
>
> You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.
>
> I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.
>
> Thanks for your review!
>
> Alex

Looking at this, there seems to be a larger problem in perl.scm with this. Many packages simply specify inputs, and I believe the same reasoning that applied to my package her will apply to those too.

Binaries are not affected by this problem, as we generally use wrapping scripts to explicitly include all dependencies in PERL5LIB.

Am I right in thinking that we should be systematically changing inputs to propagated-inputs in the whole of perl.scm?

Confused but eager to help,

Alex

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/3] gnu: Add perl-log-log4perl.
  2016-07-17  3:06   ` Ben Woodcroft
@ 2016-07-17 13:27     ` Ludovic Courtès
  0 siblings, 0 replies; 14+ messages in thread
From: Ludovic Courtès @ 2016-07-17 13:27 UTC (permalink / raw)
  To: Ben Woodcroft; +Cc: Alex Sassmannshausen, guix-devel

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 17/07/16 04:20, Alex Sassmannshausen wrote:
>> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
>> ---
>>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
>> index 486dbc2..fc63df3 100644
>> --- a/gnu/packages/perl.scm
>> +++ b/gnu/packages/perl.scm
>> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>>   mechanism.")
>>       (license (package-license perl))))
>>   +(define-public perl-log-log4perl
>> +  (package
>> +    (name "perl-log-log4perl")
>> +    (version "1.47")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
>> +             version
>> +             ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
>> +    (build-system perl-build-system)
>> +    (home-page
>> +     "http://search.cpan.org/dist/Log-Log4perl")
>> +    (synopsis "Log4j implementation for Perl")
>> +    (description "Log::Log4perl lets you remote-control and fine-tune the
>> +logging behaviour of your system from the outside.  It implements the widely
>> +popular (Java-based) Log4j logging package in pure Perl.
>> +
>> +For a detailed tutorial on Log::Log4perl usage, please read
>> +
>> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")
>
> Is it appropriate to wrap this URL in some tex? I'm not sure what
> would be appropriate in this case. Otherwise LGTM.

I think “For a detailed tutorial …” doesn’t belong in the description.
The description should just give an idea of what this is about, IMO.

Alex, could you also wrap module names in @code{}?

Otherwise LGTM, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-17 10:46 Alex Sassmannshausen
@ 2016-07-18  8:29 ` Ricardo Wurmus
  2016-07-18 13:09   ` Eric Bavier
  0 siblings, 1 reply; 14+ messages in thread
From: Ricardo Wurmus @ 2016-07-18  8:29 UTC (permalink / raw)
  To: Alex Sassmannshausen; +Cc: guix-devel


Alex Sassmannshausen <alex@pompo.co> writes:

> Looking at this, there seems to be a larger problem in perl.scm with
> this. Many packages simply specify inputs, and I believe the same
> reasoning that applied to my package her will apply to those too.
>
> Binaries are not affected by this problem, as we generally use
> wrapping scripts to explicitly include all dependencies in PERL5LIB.
>
> Am I right in thinking that we should be systematically changing
> inputs to propagated-inputs in the whole of perl.scm?

Yes, I think this should be done.  We have the same problem with some
Python packages.

Ideally, we would find a way to do without propagation as it has some
ugly effects, but I’m not sure if this is possible in Perl.  There were
some discussions about fixing this is Python (see the mailing list
archives) but I must admit to being not knowledgeable enough about
Python to confidently propose a patch.

~~ Ricardo

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-18  8:29 ` Ricardo Wurmus
@ 2016-07-18 13:09   ` Eric Bavier
  0 siblings, 0 replies; 14+ messages in thread
From: Eric Bavier @ 2016-07-18 13:09 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

On Mon, 18 Jul 2016 10:29:41 +0200
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Alex Sassmannshausen <alex@pompo.co> writes:
> 
> > Looking at this, there seems to be a larger problem in perl.scm with
> > this. Many packages simply specify inputs, and I believe the same
> > reasoning that applied to my package her will apply to those too.
> >
> > Binaries are not affected by this problem, as we generally use
> > wrapping scripts to explicitly include all dependencies in PERL5LIB.
> >
> > Am I right in thinking that we should be systematically changing
> > inputs to propagated-inputs in the whole of perl.scm?  
> 
> Yes, I think this should be done.  We have the same problem with some
> Python packages.

Though, it's not quite as simple as propagate-all-inputs.  Some care
must be taken, since many inputs are for tests only.  While some
packages have test-only inputs in native-inputs, this is not
universally true.

`~Eric

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
  2016-07-28 10:56 [PATCH 0/3] Perl log patches fixed Alex Sassmannshausen
@ 2016-07-28 10:56 ` Alex Sassmannshausen
  0 siblings, 0 replies; 14+ messages in thread
From: Alex Sassmannshausen @ 2016-07-28 10:56 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index abdc819..6513892 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,31 @@ worrying about whether the application has chosen (or will ever choose) a
 logging mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "@code{Log::Any::Adapter::Log4perl} provides a
+@code{Log::Any} adapter using @code{Log::Log4perl} for logging.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")
-- 
2.8.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-07-28 10:57 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
2016-07-17  3:04   ` Ben Woodcroft
2016-07-16 18:20 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
2016-07-17  3:06   ` Ben Woodcroft
2016-07-17 13:27     ` Ludovic Courtès
2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
2016-07-17  3:10   ` Ben Woodcroft
2016-07-17  8:44   ` Ricardo Wurmus
  -- strict thread matches above, loose matches on Subject: below --
2016-07-17 10:17 Alex Sassmannshausen
2016-07-17 10:46 Alex Sassmannshausen
2016-07-18  8:29 ` Ricardo Wurmus
2016-07-18 13:09   ` Eric Bavier
2016-07-28 10:56 [PATCH 0/3] Perl log patches fixed Alex Sassmannshausen
2016-07-28 10:56 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).