From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl. Date: Mon, 18 Jul 2016 08:09:15 -0500 Message-ID: <20160718080915.4c0b5b0e@openmailbox.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP8Ig-0008O4-Dv for guix-devel@gnu.org; Mon, 18 Jul 2016 09:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP8Ia-0002i4-MF for guix-devel@gnu.org; Mon, 18 Jul 2016 09:09:33 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:39615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP8Ia-0002ht-CL for guix-devel@gnu.org; Mon, 18 Jul 2016 09:09:28 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel On Mon, 18 Jul 2016 10:29:41 +0200 Ricardo Wurmus wrote: > Alex Sassmannshausen writes: > > > Looking at this, there seems to be a larger problem in perl.scm with > > this. Many packages simply specify inputs, and I believe the same > > reasoning that applied to my package her will apply to those too. > > > > Binaries are not affected by this problem, as we generally use > > wrapping scripts to explicitly include all dependencies in PERL5LIB. > > > > Am I right in thinking that we should be systematically changing > > inputs to propagated-inputs in the whole of perl.scm? > > Yes, I think this should be done. We have the same problem with some > Python packages. Though, it's not quite as simple as propagate-all-inputs. Some care must be taken, since many inputs are for tests only. While some packages have test-only inputs in native-inputs, this is not universally true. `~Eric