[PATCH 0/3] Add perl-log modules

[PATCH 0/3] Add perl-log modules

[Alex Sassmannshausen]

Hello,

The following 3 patches add perl-log modules.  As per usual they pass lint and
a pure environment build.

I now have commit access, but just to be sure I will continue to wait for
review for the next few submissions of even simple packages before committing
them myself.

Apologies for the confused email configuration — my actual smtp server is
currently having problems :-(

Best wishes

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

-- 
2.8.4

[PATCH 1/3] gnu: Add perl-log-any.

[Alex Sassmannshausen]

* gnu/packages/perl.scm (perl-log-any): New variable.
---
 gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index aed2a61..486dbc2 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2939,6 +2939,37 @@ either uses the first module it finds or throws an error.")
 versa.")
     (license (package-license perl))))
 
+(define-public perl-log-any
+  (package
+    (name "perl-log-any")
+    (version "1.040")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0r1q7cclgwl24gzdnjzvd8y0r7j17dngjk492x35w198zhdj2ncp"))))
+    (build-system perl-build-system)
+    (home-page "http://search.cpan.org/dist/Log-Any")
+    (synopsis "Bringing loggers and listeners together")
+    (description "Log::Any provides a standard log production API for
+modules.  Log::Any::Adapter allows applications to choose the mechanism for log
+consumption, whether screen, file or another logging mechanism like
+Log::Dispatch or Log::Log4perl.
+
+A CPAN module uses Log::Any to get a log producer object.  An application, in
+turn, may choose one or more logging mechanisms via Log::Any::Adapter, or none
+at all.
+
+Log::Any has a very tiny footprint and no dependencies beyond Perl 5.8.1,
+which makes it appropriate for even small CPAN modules to use.  It defaults to
+'null' logging activity, so a module can safely log without worrying about
+whether the application has chosen (or will ever choose) a logging
+mechanism.")
+    (license (package-license perl))))
+
 (define-public perl-log-report-optional
   (package
     (name "perl-log-report-optional")
-- 
2.8.4

Re: [PATCH 1/3] gnu: Add perl-log-any.

[Ben Woodcroft]

Thanks. I was in the process of packaging log4perl also, you beat me to it.

On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any): New variable.
> ---
>   gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index aed2a61..486dbc2 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2939,6 +2939,37 @@ either uses the first module it finds or throws an error.")
>   versa.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any
> +  (package
> +    (name "perl-log-any")
> +    (version "1.040")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0r1q7cclgwl24gzdnjzvd8y0r7j17dngjk492x35w198zhdj2ncp"))))
> +    (build-system perl-build-system)
> +    (home-page "http://search.cpan.org/dist/Log-Any")
> +    (synopsis "Bringing loggers and listeners together")
> +    (description "Log::Any provides a standard log production API for
> +modules.  Log::Any::Adapter allows applications to choose the mechanism for log
> +consumption, whether screen, file or another logging mechanism like
> +Log::Dispatch or Log::Log4perl.
> +
> +A CPAN module uses Log::Any to get a log producer object.  An application, in
> +turn, may choose one or more logging mechanisms via Log::Any::Adapter, or none
> +at all.
> +
> +Log::Any has a very tiny footprint and no dependencies beyond Perl 5.8.1,

A reference to the specific Perl version is a bit out of place, no? 
Maybe 'no dependencies beyond Perl itself'. Otherwise LGTM.

> +which makes it appropriate for even small CPAN modules to use.  It defaults to
> +'null' logging activity, so a module can safely log without worrying about
> +whether the application has chosen (or will ever choose) a logging
> +mechanism.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-report-optional
>     (package
>       (name "perl-log-report-optional")

[PATCH 2/3] gnu: Add perl-log-log4perl.

[Alex Sassmannshausen]

* gnu/packages/perl.scm (perl-log-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 486dbc2..fc63df3 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-log4perl
+  (package
+    (name "perl-log-log4perl")
+    (version "1.47")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
+    (build-system perl-build-system)
+    (home-page
+     "http://search.cpan.org/dist/Log-Log4perl")
+    (synopsis "Log4j implementation for Perl")
+    (description "Log::Log4perl lets you remote-control and fine-tune the
+logging behaviour of your system from the outside.  It implements the widely
+popular (Java-based) Log4j logging package in pure Perl.
+
+For a detailed tutorial on Log::Log4perl usage, please read
+
+http://www.perl.com/pub/a/2002/09/11/log4perl.html")
+    (license (package-license perl))))
+
 (define-public perl-log-report-optional
   (package
     (name "perl-log-report-optional")
-- 
2.8.4

Re: [PATCH 2/3] gnu: Add perl-log-log4perl.

[Ben Woodcroft]

On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 486dbc2..fc63df3 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-log4perl
> +  (package
> +    (name "perl-log-log4perl")
> +    (version "1.47")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
> +    (build-system perl-build-system)
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Log4perl")
> +    (synopsis "Log4j implementation for Perl")
> +    (description "Log::Log4perl lets you remote-control and fine-tune the
> +logging behaviour of your system from the outside.  It implements the widely
> +popular (Java-based) Log4j logging package in pure Perl.
> +
> +For a detailed tutorial on Log::Log4perl usage, please read
> +
> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")

Is it appropriate to wrap this URL in some tex? I'm not sure what would 
be appropriate in this case. Otherwise LGTM.

> +    (license (package-license perl))))
> +
>   (define-public perl-log-report-optional
>     (package
>       (name "perl-log-report-optional")

Re: [PATCH 2/3] gnu: Add perl-log-log4perl.

[Ludovic Courtès]

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 17/07/16 04:20, Alex Sassmannshausen wrote:
>> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
>> ---
>>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
>> index 486dbc2..fc63df3 100644
>> --- a/gnu/packages/perl.scm
>> +++ b/gnu/packages/perl.scm
>> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>>   mechanism.")
>>       (license (package-license perl))))
>>   +(define-public perl-log-log4perl
>> +  (package
>> +    (name "perl-log-log4perl")
>> +    (version "1.47")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
>> +             version
>> +             ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
>> +    (build-system perl-build-system)
>> +    (home-page
>> +     "http://search.cpan.org/dist/Log-Log4perl")
>> +    (synopsis "Log4j implementation for Perl")
>> +    (description "Log::Log4perl lets you remote-control and fine-tune the
>> +logging behaviour of your system from the outside.  It implements the widely
>> +popular (Java-based) Log4j logging package in pure Perl.
>> +
>> +For a detailed tutorial on Log::Log4perl usage, please read
>> +
>> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")
>
> Is it appropriate to wrap this URL in some tex? I'm not sure what
> would be appropriate in this case. Otherwise LGTM.

I think “For a detailed tutorial …” doesn’t belong in the description.
The description should just give an idea of what this is about, IMO.

Alex, could you also wrap module names in @code{}?

Otherwise LGTM, thanks!

Ludo’.

[PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Alex Sassmannshausen]

* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fc63df3..1f18214 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (native-inputs `(("perl-log-any" ,perl-log-any)))
+    (inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
+using Log::Log4perl for logging.  log4perl must be initialized before calling
+set.  There are no parameters.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")
-- 
2.8.4

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Ben Woodcroft]

On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)

This is both an input and a native-input - I imagine the former is best.

> +       ("perl-log-log4perl" ,perl-log-log4perl)))
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
> +    (synopsis "Log::Any adapter for Log::Log4perl")
> +    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
> +using Log::Log4perl for logging.  log4perl must be initialized before calling
> +set.  There are no parameters.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-log4perl
>     (package
>       (name "perl-log-log4perl")

OK.

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Ricardo Wurmus]

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>  mechanism.")
>      (license (package-license perl))))
>  
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)
> +       ("perl-log-log4perl" ,perl-log-log4perl)))

Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have
anything comparable to the RUNPATH feature, so inputs must be
propagated.

Have you tested using this module, e.g. in a container?

~~ Ricardo