* Rust dependency on git
@ 2019-05-24 3:22 Ivan Petkov
2019-05-24 10:45 ` Marius Bakke
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Petkov @ 2019-05-24 3:22 UTC (permalink / raw)
To: guix-devel
Hi Guix,
The latest stable rust (version 1.35.0) appears to require git as a
native-input since the tidy test (which checks for code formatting in the rust
repo) fails because it cannot run `git ls-files`.
I saw a comment in the rust package definition that git changes too frequently
to be kept as an input[1]. Is anyone aware if this is still a problem?
I'd rather avoid having to patch the test suite tools to ignore this test
if it is as simple as adding "git" as a native input.
cc Marius who added this line according to the history.
--Ivan
[1]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/rust.scm?id=e26d628b0fabf5a0aa7c4164a9558c66c61e02ab#n467
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rust dependency on git
2019-05-24 3:22 Rust dependency on git Ivan Petkov
@ 2019-05-24 10:45 ` Marius Bakke
2019-05-25 19:32 ` Ivan Petkov
0 siblings, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2019-05-24 10:45 UTC (permalink / raw)
To: Ivan Petkov, guix-devel
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
Hi Ivan,
Ivan Petkov <ivanppetkov@gmail.com> writes:
> Hi Guix,
>
> The latest stable rust (version 1.35.0) appears to require git as a
> native-input since the tidy test (which checks for code formatting in the rust
> repo) fails because it cannot run `git ls-files`.
>
> I saw a comment in the rust package definition that git changes too frequently
> to be kept as an input[1]. Is anyone aware if this is still a problem?
> I'd rather avoid having to patch the test suite tools to ignore this test
> if it is as simple as adding "git" as a native input.
I would prefer to keep Git out of the Rust bootstrap still. The reason
is that I don't want to rebuild the whole toolchain for every Git update.
Obviously there are other ways to deal with that, so it's not a very
hard opinion.
It seems odd to me that the release tarballs would run 'git ls-files'
anyway. Do they actually contain a git repository? Would it work to
simply replace the invokation with 'find'?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rust dependency on git
2019-05-24 10:45 ` Marius Bakke
@ 2019-05-25 19:32 ` Ivan Petkov
2019-07-19 5:55 ` Chris Marusich
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Petkov @ 2019-05-25 19:32 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
Hi Marius
> On May 24, 2019, at 3:45 AM, Marius Bakke <mbakke@fastmail.com> wrote:
>
> It seems odd to me that the release tarballs would run 'git ls-files'
> anyway. Do they actually contain a git repository? Would it work to
> simply replace the invokation with 'find’?
Managed to get a chance to dig into this a bit more. The tidy test as a pass
to ensure that no binary files have been accidentally committed into the
repository. It seems like a slight oversight in assuming that the test suite is
run directly on the source repo and not from a source tarball.
It only takes commenting out a single line to unblock things for building in Guix
(I'll be submitting a patch once I can verify it builds locally). I'll also try
to open an issue upstream.
Thanks,
--Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-19 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-24 3:22 Rust dependency on git Ivan Petkov
2019-05-24 10:45 ` Marius Bakke
2019-05-25 19:32 ` Ivan Petkov
2019-07-19 5:55 ` Chris Marusich
2019-07-19 15:10 ` Ivan Petkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).