unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Petkov <ivanppetkov@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Rust dependency on git
Date: Sat, 25 May 2019 12:32:30 -0700	[thread overview]
Message-ID: <F62BB77F-E462-4895-9880-DF2269FFA83F@gmail.com> (raw)
In-Reply-To: <87imu0dtbs.fsf@devup.no>

Hi Marius

> On May 24, 2019, at 3:45 AM, Marius Bakke <mbakke@fastmail.com> wrote:
> 
> It seems odd to me that the release tarballs would run 'git ls-files'
> anyway.  Do they actually contain a git repository?  Would it work to
> simply replace the invokation with 'find’?

Managed to get a chance to dig into this a bit more. The tidy test as a pass
to ensure that no binary files have been accidentally committed into the
repository. It seems like a slight oversight in assuming that the test suite is
run directly on the source repo and not from a source tarball.

It only takes commenting out a single line to unblock things for building in Guix
(I'll be submitting a patch once I can verify it builds locally). I'll also try
to open an issue upstream.

Thanks,
--Ivan

  reply	other threads:[~2019-05-25 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  3:22 Rust dependency on git Ivan Petkov
2019-05-24 10:45 ` Marius Bakke
2019-05-25 19:32   ` Ivan Petkov [this message]
2019-07-19  5:55     ` Chris Marusich
2019-07-19 15:10       ` Ivan Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F62BB77F-E462-4895-9880-DF2269FFA83F@gmail.com \
    --to=ivanppetkov@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).