* Re: 02/02: gnu: wine64-staging: Copy missing man file.
[not found] ` <20180102104045.DDA98206A2@vcs0.savannah.gnu.org>
@ 2018-01-02 22:25 ` Ludovic Courtès
2018-01-03 10:13 ` Rutger Helling
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2018-01-02 22:25 UTC (permalink / raw)
To: guix-devel, Rutger Helling
Hi,
This is your friendly nitpicking bot! ;-)
rhelling@mykolab.com (Rutger Helling) skribis:
> "/bin/wine-preloader") (string-append
> (assoc-ref %outputs "out")
> "/bin/wine-preloader"))
> + ;; Copy the missing man file for the wine binary from wine-staging.
> + (system (string-append "gunzip < " (string-append (assoc-ref
> + %build-inputs "wine-staging")
> + "/share/man/man1/wine.1.gz") "> "
> + (string-append (assoc-ref %outputs "out")
> + "/share/man/man1/wine.1")))
> #t))
The indentation of the nested ‘string-append’ calls is misleading here
(and the nested calls are unnecessary because ‘string-append’ is n-ary.)
Also, I think it’s OK to leave the file compressed (we have a man page
compression phase anyway.)
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 02/02: gnu: wine64-staging: Copy missing man file.
2018-01-02 22:25 ` 02/02: gnu: wine64-staging: Copy missing man file Ludovic Courtès
@ 2018-01-03 10:13 ` Rutger Helling
0 siblings, 0 replies; 2+ messages in thread
From: Rutger Helling @ 2018-01-03 10:13 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
That code was indeed a bit wacky, I fixed it up.
On Tue, 02 Jan 2018 23:25:48 +0100
ludo@gnu.org (Ludovic Courtès) wrote:
> Hi,
>
> This is your friendly nitpicking bot! ;-)
>
> rhelling@mykolab.com (Rutger Helling) skribis:
>
> > "/bin/wine-preloader")
> > (string-append (assoc-ref %outputs "out")
> > "/bin/wine-preloader"))
> > + ;; Copy the missing man file for the wine binary from
> > wine-staging.
> > + (system (string-append "gunzip < " (string-append
> > (assoc-ref
> > + %build-inputs "wine-staging")
> > + "/share/man/man1/wine.1.gz")
> > "> "
> > + (string-append (assoc-ref
> > %outputs "out")
> > + "/share/man/man1/wine.1")))
> > #t))
>
> The indentation of the nested ‘string-append’ calls is misleading here
> (and the nested calls are unnecessary because ‘string-append’ is
> n-ary.)
>
> Also, I think it’s OK to leave the file compressed (we have a man page
> compression phase anyway.)
>
> Thanks!
>
> Ludo’.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-03 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180102104042.1024.9064@vcs0.savannah.gnu.org>
[not found] ` <20180102104045.DDA98206A2@vcs0.savannah.gnu.org>
2018-01-02 22:25 ` 02/02: gnu: wine64-staging: Copy missing man file Ludovic Courtès
2018-01-03 10:13 ` Rutger Helling
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).