From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rutger Helling <rhelling@mykolab.com>
Subject: Re: 02/02: gnu: wine64-staging: Copy missing man file.
Date: Wed, 3 Jan 2018 11:13:52 +0100
Message-ID: <20180103111352.0e6a25fa@mykolab.com>
References: <20180102104042.1024.9064@vcs0.savannah.gnu.org>
	<20180102104045.DDA98206A2@vcs0.savannah.gnu.org>
	<87vagjx5hv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/u=nxij3ihfyLLPwlWvfB15h";
	protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51846)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rhelling@mykolab.com>) id 1eWg3q-0003v4-E0
	for guix-devel@gnu.org; Wed, 03 Jan 2018 05:14:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rhelling@mykolab.com>) id 1eWg3n-0000uR-7N
	for guix-devel@gnu.org; Wed, 03 Jan 2018 05:14:14 -0500
In-Reply-To: <87vagjx5hv.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

--Sig_/u=nxij3ihfyLLPwlWvfB15h
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

That code was indeed a bit wacky, I fixed it up.

On Tue, 02 Jan 2018 23:25:48 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Hi,
>=20
> This is your friendly nitpicking bot!  ;-)
>=20
> rhelling@mykolab.com (Rutger Helling) skribis:
>=20
> >                                         "/bin/wine-preloader")
> > (string-append (assoc-ref %outputs "out")
> >                                         "/bin/wine-preloader"))
> > +             ;; Copy the missing man file for the wine binary from
> > wine-staging.
> > +             (system (string-append "gunzip < " (string-append
> > (assoc-ref
> > +                                    %build-inputs "wine-staging")
> > +                                    "/share/man/man1/wine.1.gz")
> > "> "
> > +                                    (string-append (assoc-ref
> > %outputs "out")
> > +                                    "/share/man/man1/wine.1")))
> >               #t)) =20
>=20
> The indentation of the nested =E2=80=98string-append=E2=80=99 calls is mi=
sleading here
> (and the nested calls are unnecessary because =E2=80=98string-append=E2=
=80=99 is
> n-ary.)
>=20
> Also, I think it=E2=80=99s OK to leave the file compressed (we have a man=
 page
> compression phase anyway.)
>=20
> Thanks!
>=20
> Ludo=E2=80=99.


--Sig_/u=nxij3ihfyLLPwlWvfB15h
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlpMrOAACgkQ86cn20T8
yjY+sggAnB2aKcfifT7yNdBTEscO22klmqJAONTQRvkQf4G3AEexU5TY5oJ/tJrQ
A7jU6xn9dGKuvz35ORp1tX8XLKqez1cMRizdiJjLqeK+M0RFHw0FCAxG169bsdn9
aC6xmrdnjP58Sck9CuETYcsezrcsmZZ/EyNbgbE5SsIwJ8zdgQ4J3n3Wb5+J2y2H
yqiifMJRU0NZvdxwKKxlXQp8f6WGlbB/p7d2Xg8UZNr0gZr67Lc2JYGo1DnmJrME
MlM2LzDCehBWUYGXy5jXLZhXhrKaz59SL6wQ9t42kJwgFSrt6aKqmN2UvdwHs7YZ
7uD+WcJolLIGmUbC43QLXhFIizLS/Q==
=AfCh
-----END PGP SIGNATURE-----

--Sig_/u=nxij3ihfyLLPwlWvfB15h--